All of lore.kernel.org
 help / color / mirror / Atom feed
From: sjg at google.com <sjg@google.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] log: check argument of 'log level' command
Date: Sat, 13 Jun 2020 03:11:28 +0000	[thread overview]
Message-ID: <CAPnjgZ3JZZOGG_B_=5a6B+JCRiP=8Y_ayGqj-pGChNBBVjvDcA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ1YxchgJjb8==frk__3JaVMTC+EwRQwZ7GNHSzR40Znyw@mail.gmail.com>

On Sun, 31 May 2020 at 07:44, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Check that the argument provided to the 'log level' command is in the range
> between zero and CONFIG_LOG_MAX_LEVEL.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  cmd/log.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Then we should have a little test for the log command, perhaps
run_command() and then check that the default log level is set (or
not, on error).

Applied to u-boot-dm, thanks!

      parent reply	other threads:[~2020-06-13  3:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 13:44 [PATCH 1/1] log: check argument of 'log level' command Heinrich Schuchardt
2020-05-31 16:14 ` Simon Glass
2020-06-13  3:11 ` sjg at google.com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3JZZOGG_B_=5a6B+JCRiP=8Y_ayGqj-pGChNBBVjvDcA@mail.gmail.com' \
    --to=sjg@google.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.