From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Subject: Re: [PATCH 05/14] fdt: Export fdtdec_find_alias_node() function Date: Wed, 31 Oct 2012 16:50:16 -0700 Message-ID: References: <1351218671-15228-1-git-send-email-sjg@chromium.org> <1351218671-15228-6-git-send-email-sjg@chromium.org> <20121026042433.GL7222@truffula.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121026042433.GL7222@truffula.fritz.box> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de To: David Gibson Cc: Tom Rini , U-Boot Mailing List , Jerry Van Baren , Devicetree Discuss List-Id: devicetree@vger.kernel.org Hi David, On Thu, Oct 25, 2012 at 9:24 PM, David Gibson wrote: > On Thu, Oct 25, 2012 at 07:31:02PM -0700, Simon Glass wrote: >> This function is useful outside fdtdec, so export it. > > Hrm. fdt_path_offset() in libfdt itself will already look up aliases > if given a path that doesn't start with '/'. So it's not clear why > you need this function at all. Ahh, well I won't be needing that patch, then. I will submit one to remove this function. Thank you. Regards, Simon > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Wed, 31 Oct 2012 16:50:16 -0700 Subject: [U-Boot] [PATCH 05/14] fdt: Export fdtdec_find_alias_node() function In-Reply-To: <20121026042433.GL7222@truffula.fritz.box> References: <1351218671-15228-1-git-send-email-sjg@chromium.org> <1351218671-15228-6-git-send-email-sjg@chromium.org> <20121026042433.GL7222@truffula.fritz.box> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi David, On Thu, Oct 25, 2012 at 9:24 PM, David Gibson wrote: > On Thu, Oct 25, 2012 at 07:31:02PM -0700, Simon Glass wrote: >> This function is useful outside fdtdec, so export it. > > Hrm. fdt_path_offset() in libfdt itself will already look up aliases > if given a path that doesn't start with '/'. So it's not clear why > you need this function at all. Ahh, well I won't be needing that patch, then. I will submit one to remove this function. Thank you. Regards, Simon > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson