From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Wed, 6 May 2015 09:01:07 -0600 Subject: [U-Boot] [RFC PATCH v1] Makefile: Add U_BOOT_TZ and include in version In-Reply-To: References: <1430354303-30200-1-git-send-email-judge.packham@gmail.com> <1430354303-30200-2-git-send-email-judge.packham@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Chris, On 5 May 2015 at 23:38, Chris Packham wrote: > Hi, > > On Thu, Apr 30, 2015 at 12:38 PM, Chris Packham wrote: >> Define U_BOOT_TZ alongside U_BOOT_TIME and U_BOOT_DATE and use it to >> include the timezone in the version output. >> >> Signed-off-by: Chris Packham >> --- >> >> Makefile | 3 ++- >> include/version.h | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 1e52008..c6b8d3f 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1230,7 +1230,8 @@ endef >> >> define filechk_timestamp.h >> (LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"'; \ >> - LC_ALL=C date +'#define U_BOOT_TIME "%T"') >> + LC_ALL=C date +'#define U_BOOT_TIME "%T"'; \ >> + LC_ALL=C date +'#define U_BOOT_TZ "%Z"') >> endef >> >> $(version_h): include/config/uboot.release FORCE >> diff --git a/include/version.h b/include/version.h >> index d6c7cf2..777e9f6 100644 >> --- a/include/version.h >> +++ b/include/version.h >> @@ -19,7 +19,7 @@ >> #endif >> >> #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \ >> - U_BOOT_TIME ")" CONFIG_IDENT_STRING >> + U_BOOT_TIME " " U_BOOT_TZ ")" CONFIG_IDENT_STRING >> >> #ifndef __ASSEMBLY__ >> extern const char version_string[]; >> -- >> 2.3.5 >> > > Any feedback? I see I've now missed the merge window (sending the > patch as RFC on the day before it closed didn't help, sorry about > that). But is the general idea OK for when I re-submit when the next > merge window opens? Seems like a reasonable idea to me. Acked-by: Simon Glass Tested-by: Simon Glass Regards, Simon