All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Tom Rini <trini@konsulko.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	 Alexandru Gagniuc <mr.nuke.me@gmail.com>,
	Andre Przywara <andre.przywara@arm.com>,
	 Artem Lapkin <email2tema@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	 Joe Hershberger <joe.hershberger@ni.com>,
	Leo Yu-Chi Liang <ycliang@andestech.com>,
	 Marek Vasut <marex@denx.de>, Michal Simek <michal.simek@amd.com>,
	 Philippe Reynes <philippe.reynes@softathome.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 8/8] image: Drop some other #ifdefs in image-board.c
Date: Wed, 14 Sep 2022 11:10:55 -0600	[thread overview]
Message-ID: <CAPnjgZ3LYw4ryTPGUnf_WuWC+jspMQfDUo9iDe7z6M296tXkoQ@mail.gmail.com> (raw)
In-Reply-To: <1cdc5b12-597b-1a7d-0708-81b23e0cc6dd@gmx.de>

Hi Heinrich,

On Wed, 14 Sept 2022 at 10:22, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 8/28/22 20:32, Simon Glass wrote:
> > Remove all but a few that are difficult, relying on legacy CONFIG options
> > or optional global_data fields.
> >
> > Drop the duplicate function name in the comment for boot_get_cmdline().
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >   boot/image-board.c | 67 +++++++++++++++++++++++++---------------------
> >   include/image.h    |  6 +++++
> >   2 files changed, 42 insertions(+), 31 deletions(-)
> >
> > diff --git a/boot/image-board.c b/boot/image-board.c
> > index 7a17ffb7f7f..1be0a359aba 100644
> > --- a/boot/image-board.c
> > +++ b/boot/image-board.c
> > @@ -16,6 +16,7 @@
> >   #include <fpga.h>
> >   #include <image.h>
> >   #include <init.h>
> > +#include <log.h>
>
> This looks like an unrelated change.

Yes, probably left in after some debugging. But it doesn't hurt, since
at present log.h is being included by one of the other includes...

Regards,
Simon

  reply	other threads:[~2022-09-14 17:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-28 18:32 [PATCH 0/8] image: Refactor ramdisk code to avoid #ifdef Simon Glass
2022-08-28 18:32 ` [PATCH 1/8] image: Fix up ANDROID_BOOT_IMAGE ramdisk code Simon Glass
2022-08-28 18:32 ` [PATCH 2/8] image: Track when ramdisk processing is completed Simon Glass
2022-08-28 18:32 ` [PATCH 3/8] image: Drop #ifdefs for LEGACY_IMAGE_FORMAT Simon Glass
2022-08-28 18:32 ` [PATCH 4/8] image: Drop one #ifdef for FIT Simon Glass
2022-08-28 18:32 ` [PATCH 5/8] image: Drop another " Simon Glass
2022-08-28 18:32 ` [PATCH 6/8] image: Drop remaining FIT #ifdef Simon Glass
2022-08-28 18:32 ` [PATCH 7/8] image: Correct indentation in select_ramdisk() Simon Glass
2022-08-28 18:32 ` [PATCH 8/8] image: Drop some other #ifdefs in image-board.c Simon Glass
2022-09-14 16:22   ` Heinrich Schuchardt
2022-09-14 17:10     ` Simon Glass [this message]
2022-09-14 15:53 ` [PATCH 0/8] image: Refactor ramdisk code to avoid #ifdef Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3LYw4ryTPGUnf_WuWC+jspMQfDUo9iDe7z6M296tXkoQ@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=andre.przywara@arm.com \
    --cc=email2tema@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=joe.hershberger@ni.com \
    --cc=marex@denx.de \
    --cc=michal.simek@amd.com \
    --cc=mr.nuke.me@gmail.com \
    --cc=narmstrong@baylibre.com \
    --cc=philippe.reynes@softathome.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.