From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29EA6ECAAD3 for ; Thu, 1 Sep 2022 14:35:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E9B0B84103; Thu, 1 Sep 2022 16:35:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MBFgTLb2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 54B0484895; Thu, 1 Sep 2022 16:35:00 +0200 (CEST) Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AF3068402F for ; Thu, 1 Sep 2022 16:34:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-33dc345ad78so338910077b3.3 for ; Thu, 01 Sep 2022 07:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=lODDBiCzBwk8ra90ppoZLPkEeCx2MAxXBHxU/lXMbdc=; b=MBFgTLb2BwtOje1TxwaJ7nL5nV4TvxYLlIdfJ0k+jQqnlkKfNBdPyeOhqedDvDeN7D iIjA0MDPcAnKqCZL6UoNIIFMJdKMmOxr16cBaSlsobvOiCFm4wETZrDDEE+QamUrzt8b G7cTBu4lr/AnngUHvGm7EMWxPW2v5qHy3KlUg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=lODDBiCzBwk8ra90ppoZLPkEeCx2MAxXBHxU/lXMbdc=; b=FJIIB0p3bpKxjcMD/sdi9MQ9BE5GCMnpl4TWiIQy+GLeNCNn1baemb90uw+KXfAG3z 8/QDk4boy8oNfWb56QKm3Pp3r2ukJcyGlCbVMse27PX4I4n1ChE/OfjiVKoT31EZ/Jq1 YF8hoVaM37DfFIeABXWZocsNLAcb3ClpsL9vWkMxlrr/jU1x9UiHrhfDafp4UBlh20yK Iq2qYCaZ3JI81wYW1JC0Sa7cr2G6GHFzcEhCkzz4KahZoaGz8G+nywP+gH6JPbKV4hGo r8tcOn5v9GRaNC63ahgeKmmdBqOSXl4E56Yvoru6tMyDgRqKXzNOrUmi1hySv5d9ujIc pT8Q== X-Gm-Message-State: ACgBeo3ieeJHlqm+gaqVES02iF1H14sqm5OClbTUM5ZtX7qpViGr1LXf g5m+LQn5sX2L1lcLtz/VrK3K0FSIif+L156xJoMLWQ== X-Google-Smtp-Source: AA6agR62IG7GRPXCxoaIvJB1BSCUXSitaMJ/CwcLrce9/PhaUwoGm5rF5WFmnowIpR1aQsB50TL9/2wvxYFSnKQfgAc= X-Received: by 2002:a0d:d850:0:b0:340:d2c0:b022 with SMTP id a77-20020a0dd850000000b00340d2c0b022mr20502808ywe.469.1662042896013; Thu, 01 Sep 2022 07:34:56 -0700 (PDT) MIME-Version: 1.0 References: <20220831155514.110128-1-foss+uboot@0leil.net> <915fb555-a8aa-f347-5a59-d17204b5c477@weidmueller.com> In-Reply-To: <915fb555-a8aa-f347-5a59-d17204b5c477@weidmueller.com> From: Simon Glass Date: Thu, 1 Sep 2022 08:34:44 -0600 Message-ID: Subject: Re: [PATCH] binman: btool: gzip: fix packer name so that binary can be found To: Stefan Herbrechtsmeier Cc: Quentin Schulz , Alper Nebi Yasak , Stefan Herbrechtsmeier , U-Boot Mailing List , Quentin Schulz Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Stefan, On Thu, 1 Sept 2022 at 00:12, Stefan Herbrechtsmeier wrote: > > Hi Quentin, > > Am 31.08.2022 um 19:44 schrieb Simon Glass: > > On Wed, 31 Aug 2022 at 09:55, Quentin Schulz wrote: > >> > >> From: Quentin Schulz > >> > >> The binary is looked on the system by the suffix of the packer class. > >> This means binman was looking for btool_gzip on the system and not gzip. > > Are you sure? I test it and the name is already gzip because the bintool > is requested as gzip. The find_bintool_class function only change the > class name. When I tested it, it was not picking up the correct version without this patch. > > >> Therefore, let's pass "gzip" as the name so that it can be found and > >> used. > >> > >> Fixes: 0f369d79925a ("binman: Add gzip bintool") > >> Signed-off-by: Quentin Schulz > >> --- > >> tools/binman/btool/btool_gzip.py | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Simon Glass > > > > Oops! I wonder how we could test this? One way would be to require > > those tools to be present and write a test that reads the version, I > > suppose. > > We already have a test for the compressions: > testCompUtilVersions > > Regards > Stefan Regards, Simon