From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE205C05027 for ; Thu, 26 Jan 2023 19:15:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8E7B3855B5; Thu, 26 Jan 2023 20:15:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Cp4WuDFk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 81E1E855B5; Thu, 26 Jan 2023 20:15:01 +0100 (CET) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 17CB985528 for ; Thu, 26 Jan 2023 20:14:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x529.google.com with SMTP id s3so2820096edd.4 for ; Thu, 26 Jan 2023 11:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5Nr+X6jw+vDAABDozwSLsUURiWwnWgmfrsHNBMOorsE=; b=Cp4WuDFk/czAjORU6sZ14wZ06mp/WQKlK40jnitrrfNjzm+XLVTZXm8iOadxKb4uNo n0i18SXYrIFU6WpcyrYt1mTNjgy+kOK2ZCL8A05fzZDh/X6iEpXypyK7ZMs70uVzC+s6 jaZRpvLMD2XyPe828X/3trC/PFpkT+ysaI1Gs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Nr+X6jw+vDAABDozwSLsUURiWwnWgmfrsHNBMOorsE=; b=kkcBtWr23Q3BBrG2pdMN7QbIbDxHHuPK0iv9vs+6Obc0JTyoS/tc0oyLvKBVPDqeaq ytcQ1UMk42sqEQggrwr/qlX/08grEAruXP5Tqt94Un215VhRFdgXAoxPUQvh4HSMVtJw dQgZVSZlCAVJM/n9GY7kPQNu638B0UPCU1BvDzE7a7APuZhV0ROYuJvC6I09KSgZeEIQ PsqWoiXJR/sh6aut9hCgQEkke+KCmyS1URJ7OlyibZJMFtGRnMtU3nOLdLKshNEGdYGd XR9HZJHjAm7XE2UN6f8lOA+qfUjqiR9dKyOrgqf7U6LMsO7WpWmvge2QyKsNikptaKw2 hzUA== X-Gm-Message-State: AFqh2kqWQxGm9B7EXYi42Tq1bgCODP45JLyQ2LKTTwByJeBhTGk+Gmbe 0qBwSufOhjObDOa/Ty1mEhD3IMpwXESBClWjOmOq9dXmjX5XdbqvGMs= X-Google-Smtp-Source: AMrXdXvKuSsFM5gG5bXIo9VCGJrvF9I3aU5XQC4hpdcI8bQiFEjEWsTEVkUNpa9Zp7QZIrVjTwapF2d9ujgCCdQn8/s= X-Received: by 2002:a05:6402:3814:b0:49e:6501:57a2 with SMTP id es20-20020a056402381400b0049e650157a2mr4953005edb.43.1674760496965; Thu, 26 Jan 2023 11:14:56 -0800 (PST) MIME-Version: 1.0 References: <20230125222741.303259-1-jagan@edgeble.ai> <2efd56b6-4dc9-cd77-3792-e60142faa6ae@kwiboo.se> <64443c40-03b1-bfe2-23fe-ad61236d7dde@kwiboo.se> In-Reply-To: From: Simon Glass Date: Thu, 26 Jan 2023 12:14:44 -0700 Message-ID: Subject: Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support To: Jagan Teki Cc: Jonas Karlman , Kever Yang , Philipp Tomsich , fatorangecat@189.cn, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Jagan, On Thu, 26 Jan 2023 at 11:27, Jagan Teki wrote: > > Hi Simon, > > On Thu, 26 Jan 2023 at 23:34, Simon Glass wrote: > > > > Hi Jagan, > > > > On Thu, 26 Jan 2023 at 10:42, Jagan Teki wrote: > > > > > > On Thu, 26 Jan 2023 at 22:28, Jonas Karlman wrote: > > > > > > > > Hi Jagan, > > > > On 2023-01-26 17:51, Jagan Teki wrote: > > > > > Hi Jonas, > > > > > > > > > > On Thu, 26 Jan 2023 at 04:17, Jonas Karlman wro= te: > > > > >> > > > > >> Hi Jagan, > > > > >> > > > > >> On 2023-01-25 23:27, Jagan Teki wrote: > > > > >>> This series support Rockchip RK3588. All the device tree files = are > > > > >>> synced from linux-next with the proper SHA1 mentioned in the co= mmit > > > > >>> messages. > > > > >>> > > > > >>> Unfortunately, the BL31 from rkbin is not compatible with U-Boo= t so > > > > >>> it is failing to load ATF entry from SPL and hang. > > > > >>> > > > > >>> Verified below BL31 versions, > > > > >>> bl31-v1.15 > > > > >>> bl31-v1.21 > > > > >>> bl31-v1.22 > > > > >>> bl31-v1.23 > > > > >>> bl31-v1.24 > > > > >>> bl31-v1.25 > > > > >>> bl31-v1.26 > > > > >>> > > > > >>> Rever-engineered with respect to rockchip u-boot by using the s= ame > > > > >>> FIT_GENERATOR being used in Mainline, rockchip u-boot is bootin= g but > > > > >>> mainline showing the same issue. > > > > >>> > > > > >>> Log: > > > > >>> > > > > >>> LPDDR4X, 2112MHz01-00642-g6bdfd31756-dirty (Jan 26 2023 =EF=BF= =BD=EF=BF=BD=EF=BF=BD3:44:34 +0530) > > > > >>> channel[0] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS= =3D2 Die BW=3D8 Size=3D4096MB > > > > >>> channel[1] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS= =3D2 Die BW=3D8 Size=3D4096MB > > > > >>> channel[2] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS= =3D2 Die BW=3D8 Size=3D4096MB > > > > >>> channel[3] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS= =3D2 Die BW=3D8 Size=3D4096MB > > > > >>> change to F1: 528MHz > > > > >>> change to F2: 1068MHz > > > > >>> change to F3: 1560MHz > > > > >>> change to F0: 2112MHz > > > > >>> out > > > > >>> > > > > >>> U-Boot SPL 2023.01-00642-g6bdfd31756-dirty (Jan 26 2023 - 03:44= :34 +0530) > > > > >>> Trying to boot from MMC1 > > > > >>> bl31_entry: atf_entry start > > > > >>> << hang >> > > > > >>> > > > > >>> Any information on BL31 for RK3588 please share. > > > > >> > > > > >> I had a similar strange booing issue with RK3568 and mainline U-= Boot, > > > > >> turned out to be related to all parts of ATF not being properly = loaded > > > > >> into PMU SRAM. > > > > >> > > > > >> Using my series at [1] I managed to get ATF to be fully loaded i= nto > > > > >> PMU SRAM. Using CONFIG_SPL_FIT_SIGNATURE=3Dy helped me finding o= ut that > > > > >> the segment being loaded ended up corrupted. > > > > >> > > > > >> The use of 512 bytes alignment of the FIT helped mitigate that i= ssue. > > > > >> Vendor U-Boot use a bounce buffer for all parts that is written = into > > > > >> SRAM (anything loaded outside the gd->ram_base to gd->ram_top ra= nge). > > > > >> > > > > >> You can also find newer bl31 at [2], up to version v1.32. > > > > >> > > > > >> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=3D33= 7891>>> [2] https://gitlab.com/rk3588_linux/rk/rkbin/-/tree/linux-5.10-gen-= rkr3.5/bin/rk35>> > > > > > Thanks for the details. I did apply this set on the master. No ch= ange > > > > > in the behavior, used BL31 and ddr from [2] as well as in > > > > > rkbin/master. > > > > > > > > I did some tests on my Radxa ROCK 3 Model B with CONFIG_SPL_FIT_SIG= NATURE=3Dy > > > > and it looked like it failed to read data into memory, see below. > > > > > > > > It also looks like the sdhci compatible is not supported by the dri= ver. > > > > Something that may need to be added to driver to properly read data= ? > > > > > > > > > > > > DDR V1.09 a930779e06 typ 22/11/21-17:50:56 > > > > LPDDR4X, 2112MHz > > > > channel[0] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2= Die BW=3D16 Size=3D2048MB > > > > channel[1] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2= Die BW=3D16 Size=3D2048MB > > > > channel[2] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2= Die BW=3D16 Size=3D2048MB > > > > channel[3] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2= Die BW=3D16 Size=3D2048MB > > > > Manufacturer ID:0x6 > > > > CH0 RX Vref:31.7%, TX Vref:21.8%,20.8% > > > > CH1 RX Vref:31.7%, TX Vref:21.8%,21.8% > > > > CH2 RX Vref:32.7%, TX Vref:22.8%,21.8% > > > > CH3 RX Vref:32.7%, TX Vref:21.8%,20.8% > > > > change to F1: 528MHz > > > > change to F2: 1068MHz > > > > change to F3: 1560MHz > > > > change to F0: 2112MHz > > > > out > > > > > > > > U-Boot SPL 2023.01 (Jan 26 2023 - 00:24:53 +0000) > > > > Trying to boot from MMC1 > > > > ## Checking hash(es) for config config_1 ... OK > > > > ## Checking hash(es) for Image atf_1 ... sha256 error! > > > > Bad hash value for 'hash' hash node in 'atf_1' image node > > > > mmc_load_image_raw_sector: mmc block read error > > > > Trying to boot from MMC1 > > > > ## Checking hash(es) for config config_1 ... OK > > > > ## Checking hash(es) for Image atf_1 ... sha256 error! > > > > Bad hash value for 'hash' hash node in 'atf_1' image node > > > > > > Look like this is something wrong with your patch series or master > > > changes on binman, not with the driver. I have observed the same if I > > > enable CONFIG_SPL_FIT_SIGNATURE. > > > > There are some more changes in dm/master that I'm about to pull in. > > One of them from Jonas Karlman adds hash nodes so may be involved. > > I found the same issue on the dm/master > > U-Boot SPL 2023.01-00176-gb21fb7a9c0 (Jan 26 2023 - 23:55:11 +0530) > Trying to boot from MMC1 > ## Checking hash(es) for config config-1 ... OK > ## Checking hash(es) for Image atf-1 ... sha256 error! > Bad hash value for 'hash' hash node in 'atf-1' image node > mmc_load_image_raw_sector: mmc block read error > SPL: failed to boot from all boot devices > ### ERROR ### Please RESET the board ### Is the FIT image broken? You can use check_sign or dump_image to see. Regards, Simon