From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Wed, 18 Nov 2015 08:53:37 -0700
Subject: [U-Boot] [PATCH v2 00/26] usb: Drop requirement for USB
	unbinding, add tests
In-Reply-To: <CAPnjgZ1KL1uu1rgN2o0aBarOioLkyHkAqw2V2THxbS0bxQvsDg@mail.gmail.com>
References: <1447051688-24936-1-git-send-email-sjg@chromium.org>
 <564055DD.8040102@redhat.com>
 <CAPnjgZ1KL1uu1rgN2o0aBarOioLkyHkAqw2V2THxbS0bxQvsDg@mail.gmail.com>
Message-ID: <CAPnjgZ3OgS0SqDNuU1gOuLRt9s9WDOCbYAe_s71pivggDajoag@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 9 November 2015 at 09:54, Simon Glass <sjg@chromium.org> wrote:
>
> Hi Hans,
>
> On 9 November 2015 at 00:14, Hans de Goede <hdegoede@redhat.com> wrote:
> > Hi Simon,
> >
> > On 09-11-15 07:47, Simon Glass wrote:
> >>
> >> There was quite a bit of discussion about the change that required the
> >> unbinding of USB devices for the subsystem to function correctly. E.g.
> >>
> >> https://patchwork.ozlabs.org/patch/485637/
> >>
> >> The key issue is the usb_get_dev_index() function which is not a good API
> >> for driver model. We can drop use of this function once everything is
> >> converted to driver model. Then I believe the problems raised by Hans go
> >> away. For now we can add a deprecation warning on the function.
> >>
> >> It is easy to convert USB keyboards to driver model. This series includes
> >> a patch for that.
> >>
> >> This series also includes reverts for the three commits which as discussed
> >> I would like to drop. U-Boot should be able to run normally and exit
> >> without
> >> unbinding anything.
> >>
> >> Also included are some tests for the 'usb tree' command. To make this
> >> work,
> >> console recording is implemented.
> >>
> >> Finally, a USB keyboard driver is provided for sandbox, so that this part
> >> of the stack can be tested automatically.
> >>
> >> Changes in v2:
> >> - Add various patches to support USB keyboards and additional tests
> >
> >
> > Do you have a git branch with this patch-set somewhere for me to test ?
>
> Yes I always upload branches before sending them. This one is
> u-boot-dm/usb-working. I should get better at including the branch
> name in the cover letter.
>
> I still need to write a test for having two device types which switch
> order. Now that I have a USB keyboard emulation I should be able to do
> that. I'll then see the impact on 'usb tree'. So you may want to
> review the test code only for now.
>
> Regards,
> Simon

Are there any more comments on this series please? I plan to bring it
in soon since we are already at RC1.

Regards,
Simon