From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] trace: conserve gd register
Date: Fri, 28 Jun 2019 07:55:02 -0600 [thread overview]
Message-ID: <CAPnjgZ3P3EgaKtJX5=nQmDD3yLCmoOoFB4j7xQE0e+cdWL_13g@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ2qYM+nhbvAi+wqRnDkxTe=LdexMPKwZg9rvwryU_0cTQ@mail.gmail.com>
On Sat, 22 Jun 2019 at 13:10, Simon Glass <sjg@chromium.org> wrote:
>
> On Sun, 2 Jun 2019 at 12:05, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > An UEFI application may change the value of the register that gd lives in.
> > But some of our functions like get_ticks() access this register. So we
> > have to set the gd register to the U-Boot value when entering a trace
> > point and set it back to the application value when exiting the trace
> > point.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> > lib/trace.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 49 insertions(+)
>
> Ick. I can't think of a better idea.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm/next, thanks!
prev parent reply other threads:[~2019-06-28 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 11:05 [U-Boot] [PATCH 1/1] trace: conserve gd register Heinrich Schuchardt
2019-06-22 19:10 ` Simon Glass
2019-06-28 13:55 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ3P3EgaKtJX5=nQmDD3yLCmoOoFB4j7xQE0e+cdWL_13g@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.