All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Tony Dinh <mibodhi@gmail.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Stefan Roese <sr@denx.de>, Ramon Fried <rfried.dev@gmail.com>,
	 Joe Hershberger <joe.hershberger@ni.com>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 0/3] common: Add fdt network helper
Date: Tue, 17 Aug 2021 10:09:16 -0600	[thread overview]
Message-ID: <CAPnjgZ3PP+mUn3CMNwPqkTSDz3J2h0b-8VgC=CnUbxu+pHj6yg@mail.gmail.com> (raw)
In-Reply-To: <CAJaLiFxvWgqgwQqcwQuwOgsu=Gx1XeJ36aMXaStC_nz31ZxGdQ@mail.gmail.com>

Hi Tony,

On Sun, 15 Aug 2021 at 15:28, Tony Dinh <mibodhi@gmail.com> wrote:
>
> Hi Simon,
>
> On Sun, Aug 15, 2021 at 7:10 AM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Tony,
> >
> > On Thu, 5 Aug 2021 at 22:49, Tony Dinh <mibodhi@gmail.com> wrote:
> > >
> > >
> > > At the moment, there is no common fdt helper function specific to decoding network related
> > > information from FDTs. This new helper functional group fdt_support_net is intended to be used
> > > by board-specific code within U-Boot for various network related chores.
> > >
> > > In this patch, create the 1st function fdt_get_phy_addr to parse the device tree to find
> > > the PHY addess of a specific ethernet device.
> > >
> > >
> > > Tony Dinh (3):
> > >   Add fdt network helper header file
> > >   Add fdt network helper functions
> > >   Add fdt network helper to Makefile
> > >
> > >  common/Makefile           |  2 +-
> > >  common/fdt_support_net.c  | 46 +++++++++++++++++++++++++++++++++++++++
> > >  include/fdt_support_net.h | 39 +++++++++++++++++++++++++++++++++
> > >  3 files changed, 86 insertions(+), 1 deletion(-)
> > >  create mode 100644 common/fdt_support_net.c
> > >  create mode 100644 include/fdt_support_net.h
> >
> > Can this use livetre and also have some tests?
>
> I have not enabled livetree for any of the boards I have. So I just
> modeled this using the existing ./common/fdt_support.c!
>
> I do agree we should start using livetree in fdt helpers, if I
> understood it correctly, it should work for both flattree and

OK good, yes that's right.

> livetree. Perhaps we could have another patch series after this? I am
> preparing another Kirkwood board support patch that I could hold off
> submitting and enable livetree to use that as a vehicle for testing.

I think it is better to use livetree in this patch. For testing, you
can use sandbox for testing (see for example test/dm/ofnode.c)

Regards,
Simon

  parent reply	other threads:[~2021-08-17 16:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  4:49 [PATCH 0/3] common: Add fdt network helper Tony Dinh
2021-08-06  4:49 ` [PATCH 1/3] Add fdt network helper header file Tony Dinh
2021-08-12  6:17   ` Stefan Roese
2021-08-13 22:26   ` Ramon Fried
2021-09-25 15:15   ` Simon Glass
2021-08-06  4:49 ` [PATCH 2/3] Add fdt network helper functions Tony Dinh
2021-08-12  6:15   ` Stefan Roese
2021-08-12  9:12     ` Tony Dinh
2021-08-13 22:27       ` Ramon Fried
2021-08-06  4:49 ` [PATCH 3/3] Add fdt network helper to Makefile Tony Dinh
2021-08-12  6:17   ` Stefan Roese
2021-08-13 22:28   ` Ramon Fried
2021-08-12  6:18 ` [PATCH 0/3] common: Add fdt network helper Stefan Roese
2021-08-15  0:17 ` [PATCH v2 1/3] " Tony Dinh
2021-08-15  0:17   ` [PATCH v2 2/3] common: Add fdt network helper header file Tony Dinh
2021-08-15  0:17   ` [PATCH v2 3/3] common: Add fdt network helper functions Tony Dinh
2021-08-15 14:09 ` [PATCH 0/3] common: Add fdt network helper Simon Glass
2021-08-15 21:27   ` Tony Dinh
2021-08-16 23:36     ` Tony Dinh
2021-08-17 16:09     ` Simon Glass [this message]
2021-08-27  4:00       ` Tony Dinh
2021-09-01  9:21         ` Tony Dinh
2021-09-02 16:41           ` Simon Glass
2021-09-03  2:24             ` Tony Dinh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3PP+mUn3CMNwPqkTSDz3J2h0b-8VgC=CnUbxu+pHj6yg@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=joe.hershberger@ni.com \
    --cc=mibodhi@gmail.com \
    --cc=rfried.dev@gmail.com \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.