From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EE62C433F5 for ; Thu, 3 Feb 2022 22:02:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2177B82146; Thu, 3 Feb 2022 23:02:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GuuiISC0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 90FD9836AD; Thu, 3 Feb 2022 23:02:18 +0100 (CET) Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A4DE48210D for ; Thu, 3 Feb 2022 23:02:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92f.google.com with SMTP id a24so7716858uat.10 for ; Thu, 03 Feb 2022 14:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7LhzTii11s68rH31pPWCmv6gH3ii9hue4dP4xwj3bJU=; b=GuuiISC0xLxkHPrPVIEHoPu1ULa26SppgRtVZbATtFWaDX8zz0gnRoUt/rrbidUQC3 vsTIN7+Rty4/0NOzUDo9of2Dq2t3aDF/At9IcrUkXxyH+mcafXBHQSRtE0WdSoQdHaSV WPj7kZtxNIxZ7zwctUbPqp3pspgN+z90B2xJE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7LhzTii11s68rH31pPWCmv6gH3ii9hue4dP4xwj3bJU=; b=DKWuAvN/qyemeyfBguWFuuJ6p7M/0goG3P3pM8AVjCvKgd3YkE+KeP5SHfJU/s1oPX Qs3/WPbVKd+8ynsup4jsqbE9nE0Q38iXXNo4/AndM20+hubCH1sqVvlbSElvQ59LJvUb UVy1EM3TzoRCcb2GLUJQJFrCco9DgY8lkDYNYbNxd7cInyL6jJGDYCeJCBH8cVXqGnX7 NFrrK9FYM6PthGVhOGjImjvLspwJS8WazqoolJq5b9pCnqkLpMDXdmYiI8CrL+noxPJD isIHLieyAahbpH6VUpGTt3K5Mwzhd10pVGxdhOkGhIJLbY/pUBBt+cur+DVXizTzBCmn cFqA== X-Gm-Message-State: AOAM5315IYO+7mW+IvspwPvbptqTwzCiwi2vlu+54EvR/YmRFIKk+0Ax CGTkgTeHNdQti+R1GVQ1ehWLNyi8IMSiwUQL7FZb/g== X-Google-Smtp-Source: ABdhPJyR7mNYd4Uzb2C5WmoLI7o3//VkTSkPzisW/L3R9mOpZTLZPWzjE4E5OIeW2HWl0rPmK5U6HU1SG16O0oZeLes= X-Received: by 2002:ab0:1e46:: with SMTP id n6mr15170uak.140.1643925734058; Thu, 03 Feb 2022 14:02:14 -0800 (PST) MIME-Version: 1.0 References: <20220203183850.10186-1-pali@kernel.org> <20220203211623.GY7515@bill-the-cat> <20220203214544.GA7515@bill-the-cat> <20220203215307.GB7515@bill-the-cat> In-Reply-To: <20220203215307.GB7515@bill-the-cat> From: Simon Glass Date: Thu, 3 Feb 2022 15:02:02 -0700 Message-ID: Subject: Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD To: Tom Rini Cc: =?UTF-8?Q?Pali_Roh=C3=A1r?= , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi, On Thu, 3 Feb 2022 at 14:53, Tom Rini wrote: > > On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote: > > On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote: > > > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Roh=C3=A1r wrote: > > > > > > > Signed-off-by: Pali Roh=C3=A1r > > > > --- > > > > > > > > I would really appreciate if U-Boot test framework starts printing > > > > deprecation warnings, instead of sending patches which directly dro= p > > > > support for some boards. > > > > > > > > There is absolutely no warning during building U-Boot for RX-51 boa= rd > > > > that this board has not been converted to DM_KEYBOARD yet. > > > > > > Please send some patch that implements what you're wanting to see for > > > how to make the warnings more visible. I do agree the warning for > > > v2022.10 only showed up after the merge to -next once v2022.01 came o= ut, > > > but it's still a fairly long time to clean up the few unconverted > > > boards. > > > > Oh, I see what's going on. Simon, the DM_KEYBOARD check isn't > > triggering for any boards. I'll look more. > > And here's where we're at. nokia_rx51 doesn't set CONFIG_KEYBOARD, so > didn't trigger the warning about migration. Every platform that sets > CONFIG_KEYBOARD is migrated. I don't know how many other platforms are > in the situation nokia_rx51 is in. Yanking out the legacy code and > seeing what fails to build, and going from there is probably the next > option. Yes. As to your questoin, none that I know of. I sent a series to drop cfb_console which was how this used to work, although in fact it hasn't worked for a while. The problem here seems to be that this board was multiple migrations behind and so was not caught. We should be able to remove the migration check. Pali, just to explain from the other POV, I am finding it increasingly frustrating dealing with ad-hoc CONFIG options, old drivers, etc. We really need to complete some of the migrations we started 6 years ago. Regards, Simon