From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sat, 7 Feb 2015 11:02:04 -0700 Subject: [U-Boot] [PATCH v2 3/3] sunxi: Normalise FEL support In-Reply-To: <54D6526A.7060404@redhat.com> References: <1423331250-8040-1-git-send-email-sjg@chromium.org> <1423331250-8040-3-git-send-email-sjg@chromium.org> <54D6526A.7060404@redhat.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Hans, On 7 February 2015 at 10:59, Hans de Goede wrote: > Hi, > > On 02/07/2015 06:47 PM, Simon Glass wrote: >> >> Make sunxi's FEL code fit with the normal U-Boot boot sequence instead of >> creating its own. There are some #ifdefs required in start.S. Future work >> will hopefully remove these. > > > About the #ifdefs, I would really like to see us move to having 1 unified > loader for sunxi, which means getting rid of them. Even though we do use > a label to return from save_boot_params, save_boot_params could still > use r0 to return stuff, like you did in your previous patch-set, or we > could add a global variable to start.S which lives in .data and gets > initialized with 0, and save_boot_params could optionally save some > skip flags there. > > Note this dropping of #ifdefs can wait till after v2015.04, for now this > patch-set should get fel mode working as before which is the goal for > v2015.04. OK. It's just as easy for me to do this now, but Albert was not keen on doing this at run-time. So if you can remove the #ifdefs by calling back into the BROM that would probably be better. For now I think Albert prefers the #ifdefs. >> This series is available at u-boot-dm, branch sunxi-working. >> >> Signed-off-by: Simon Glass >> --- >> [snip] Regards, Simon