From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374DAC433EF for ; Thu, 28 Oct 2021 17:16:52 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8620610C8 for ; Thu, 28 Oct 2021 17:16:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A8620610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75985834B5; Thu, 28 Oct 2021 19:16:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="SmAL8oKM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 81D87834A4; Thu, 28 Oct 2021 19:16:48 +0200 (CEST) Received: from mail-vk1-xa2d.google.com (mail-vk1-xa2d.google.com [IPv6:2607:f8b0:4864:20::a2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5624B834A4 for ; Thu, 28 Oct 2021 19:16:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa2d.google.com with SMTP id t127so3308199vke.13 for ; Thu, 28 Oct 2021 10:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8VZEyMvMNsjFq5wJPEdzeh002wtLcVNoq3ooK+6Gz6E=; b=SmAL8oKMEavlzbxVo2XyLarLDe5msywuBaE0u9Shj78IN+4qGXoyocJTj1/HS/Iok4 DrnlgdjT3f0WYvAV56Bf/UXXW9XTMPpK/rwluE3n8duMNeBNBFcOa0IVB3cYi1q3LZpK uWbeEgh28eqxjjgTwxTIUO1kBfvYSAYydrWhM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8VZEyMvMNsjFq5wJPEdzeh002wtLcVNoq3ooK+6Gz6E=; b=sreePLb2l7slrTCwKCwfBjpmnCuspG730QeTEq2ZQJ0zP1r357FN1jVSPwTRz4hOGe ZBZzj9LIO0Llo6Y3K1yowEyqER/UF4ocyIDyODnE0J7vTn3bLdAT8F5VBiikY+McA/dK aXnyhXnxrGAg0GbhjTl3shJ6LCZCc+Fmo3etkWZacWC2qV4wpr+hB/gBT4xyiKv1A3Ty MmvfjdI4R+Tbt/5mk8meT9sI2HkzXBlapM8kecy/v1bFWNUDhj2YXa9HYdbfaTPL897R WJVqfSbteKBUl0Lz+khfzq8cQgY6dHKQtsdKQTYRFz+xosAnajgd/yqJdgab7dJmtPEe EGRQ== X-Gm-Message-State: AOAM532PD9hZmWnx1qWdRg5bPBoadU/azxT83ZeYv6EkwLQUDxnSBaBI XlwmdoGxgWo6dSA+NMrsPgvPWmY9OlZFTHTO6zgcMA== X-Google-Smtp-Source: ABdhPJztKyyghReal7hTuTzLINjMe0dRb3RlsEA+J6W49PyQC9v9r4ERqGcuJ06NOzEkKfgdVXk+y/WZwySfrY4Lv1c= X-Received: by 2002:a05:6122:901:: with SMTP id j1mr5669753vka.11.1635441402681; Thu, 28 Oct 2021 10:16:42 -0700 (PDT) MIME-Version: 1.0 References: <20211023232635.9195-1-sjg@chromium.org> <20211023232635.9195-29-sjg@chromium.org> <20211028164316.GB8284@bill-the-cat> In-Reply-To: <20211028164316.GB8284@bill-the-cat> From: Simon Glass Date: Thu, 28 Oct 2021 11:16:31 -0600 Message-ID: Subject: Re: [PATCH v2 41/41] RFC: Switch rpi over to use bootstd To: Tom Rini Cc: U-Boot Mailing List , Michal Simek , Heinrich Schuchardt , Ilias Apalodimas , Daniel Schwierzeck , Steffen Jaeckel , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Lukas Auer , Dennis Gilmore Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Thu, 28 Oct 2021 at 10:43, Tom Rini wrote: > > On Sat, Oct 23, 2021 at 05:26:35PM -0600, Simon Glass wrote: > > > Switch this over, for testing purposes. > > > > Signed-off-by: Simon Glass > [snip] > > #define CONFIG_EXTRA_ENV_SETTINGS \ > > "dhcpuboot=usb start; dhcp u-boot.uimg; bootm\0" \ > > + "boot_targets=mmc0 mmc1 usb0 pxe dhcp\0" \ > > So, based on this patch I went "oh, so we can still easily control the > device order, per board and also for users to tweak". Then I looked for > where boot_targets was used, saw it wasn't and looked over the > documentation patch previous to this. That's not looking easier to > configure than what we have now either. Yes, I did originally implement the boot_targets env var, then decided it should be in the device tree instead, since you can do: bootstd { compatible = "u-boot,boot-std"; bootdev-order = "mmc2", "mmc1"; }; (with nothing else in the devicetree) I made this change since it seems that boot_targets is always set in the env and should not be touched by the distro. If that is not correct I can bring the code back... BTW the MAC address was just for my testing. Regards, Simon