From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 1 Sep 2014 17:18:01 -0700 Subject: [U-Boot] [PATCH v9 11/14] buildman: Add an option to show which boards caused which errors In-Reply-To: <20140901112338.GR19374@bill-the-cat> References: <1408982315-18610-1-git-send-email-sjg@chromium.org> <1408982315-18610-12-git-send-email-sjg@chromium.org> <20140825191438.GO19374@bill-the-cat> <20140828125142.GY19374@bill-the-cat> <20140901112338.GR19374@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On 1 September 2014 04:23, Tom Rini wrote: > On Sun, Aug 31, 2014 at 10:09:44PM -0700, Simon Glass wrote: >> Hi Tom, >> >> On 28 August 2014 05:51, Tom Rini wrote: >> > On Tue, Aug 26, 2014 at 08:59:52PM -0600, Simon Glass wrote: >> >> Hi Tom, >> >> >> >> On 25 August 2014 13:14, Tom Rini wrote: >> >> > On Mon, Aug 25, 2014 at 09:58:32AM -0600, Simon Glass wrote: >> >> >> Add a -l option to display a list of offending boards against each >> >> >> error/warning line. The information will be shown in brackets as below: >> >> >> >> >> >> 02: wip >> >> >> sandbox: + sandbox >> >> >> arm: + seaboard >> >> >> +(sandbox) arch/sandbox/cpu/cpu.c: In function 'timer_get_us': >> >> >> +(sandbox) arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable] >> >> >> +(seaboard) board/nvidia/seaboard/seaboard.c: In function 'pin_mux_mmc': >> >> >> +(seaboard) board/nvidia/seaboard/seaboard.c:36:9: warning: unused variable 'fred' [-Wunused-variable] >> >> >> +(seaboard) int fred; >> >> >> +(seaboard) ^ >> >> >> >> >> >> Signed-off-by: Simon Glass >> >> > >> >> > Doing buildman ... ; buildman ... -svl (since I want to spit out the >> >> > summary at once due to how LSF mangles output to file), I don't see >> >> >> >> What is -s? >> > >> > summary. >> > >> >> > anything for what caused powerpc failures say (where there's lot of >> >> > things complaining about generic board). So something isn't right, is >> >> > this something you can reproduce locally? I'm going to make sure that >> >> > -e really is implied like the doc says. Thanks! >> >> >> >> ./tools/buildman/buildman -vl sandbox >> >> Building current source for 1 boards (1 thread, 4 jobs per thread) >> >> sandbox: + sandbox >> >> +(sandbox) arch/sandbox/cpu/cpu.c: In function ?__udelay?: >> >> +(sandbox) arch/sandbox/cpu/cpu.c:36:5: error: unknown type name ?oijew? >> >> +(sandbox) arch/sandbox/cpu/cpu.c:37:2: error: conflicting types for ?os_usleep? >> >> +(sandbox) include/os.h:155:6: note: previous declaration of >> >> ?os_usleep? was here >> >> +(sandbox) make[2]: *** [arch/sandbox/cpu/cpu.o] Error 1 >> >> +(sandbox) make[1]: *** [arch/sandbox/cpu] Error 2 >> >> +(sandbox) make: *** [sub-make] Error 2 >> >> w+(sandbox) arch/sandbox/cpu/cpu.c: In function ?do_reset?: >> >> w+(sandbox) arch/sandbox/cpu/cpu.c:27:13: warning: unused variable ?i? >> >> [-Wunused-variable] >> >> w+(sandbox) arch/sandbox/cpu/cpu.c:37:2: warning: parameter names >> >> (without types) in function declaration [enabled by default] >> >> 0 0 1 /1 sandbox >> >> >> >> This shows warnings and errors, and -e is implied (but note you should >> >> test with both series - I pushed 'buildman5' to u-boot-x86.git just in >> >> case you only have one). >> >> >> >> I might be able to repeat your problem, except for the LSF part. What >> >> command line are you using? >> > >> > I do: >> > ./tools/buildman/buildman -b master -c 1 -T 1 -j 24 \ >> > -o /tmp/trini/eldk521 -G ~/.buildman.eldk521 'arm|powerpc' >> > ./tools/buildman/buildman -b master -c 1 -T 1 -j 24 \ >> > -o /tmp/trini/eldk521 -G ~/.buildman.eldk521 'arm|powerpc' -svel >> > >> > Doing '-svl' would omit the information I expected, adding in -e worked. >> > I do it this way since LSF only lets me log raw stdout to a file so >> > doing a build then a summary pass gives me more easily readable output. >> >> OK I missed that you were doing two steps. >> >> -v is only meaningful *without* -s: it makes the *build* verbose. When >> building, -v implies -e, >> >> The summary (-s) is always verbose, so doesn't need -v. > > OK, but in step #2, -svl _doesn't_ give me information about what boards > have what problem and -svel does. You're saying -sel should work too, > but commit text (and help text?) says that -l implies -e, but it's not. -v implies -e if you are building (no -s) -v means nothing if you are not building (-s) I don't think -l implies anything. I suspect I have stuffed up something in the docs but I can't see what, so will await your response. Sorry for the trouble. Regards, Simon