From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57736C49EA6 for ; Sat, 26 Jun 2021 18:35:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3D5D61C29 for ; Sat, 26 Jun 2021 18:35:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3D5D61C29 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C51182D85; Sat, 26 Jun 2021 20:32:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="gYc06G+O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2F6F182D80; Sat, 26 Jun 2021 20:32:32 +0200 (CEST) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AFDF382D72 for ; Sat, 26 Jun 2021 20:32:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x32e.google.com with SMTP id g19-20020a9d12930000b0290457fde18ad0so13243912otg.1 for ; Sat, 26 Jun 2021 11:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tGBZ7EtQecfXqGF0FUUnYfCQ+LoAaSvvjPGcNSSnTHE=; b=gYc06G+OP+uS++vOyiYWh00gFV5kRqgFd6OQmjsU944mhrDo4gjwYPOSXjX5xoYp6o 1KleDBFUtbioIrzzyKxFn6+Z6ZDKC/NID9iG7gnRjxwMVrSmbuoer/fc9F+SN7wJxRbf wumHZiheZWetP0455J4UuUmEleduochsIAT2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tGBZ7EtQecfXqGF0FUUnYfCQ+LoAaSvvjPGcNSSnTHE=; b=LaCRZmqb5x0Sh1LncSHa0NjbgqhEqfSSHAHXBaFyzGmBcfMrXp0xKfBZleoV8ooPUy HssPyanfCpuqZzwNTCBuQ4pw6sQRqS9r//5BqFaqxXhgRZFUKy6y/k1H/QNlPL6kOUmO PEZVsByug5zALpI+N8fVTbHcSkG3og819lt3rMQgaUUOklEY5y+6yP26hxCL3ajbWyuZ 2C1Qy/xdO2kATCiKOBBIA43Jc/h+3ee/aP1z6X+K0ts64QYwPbCyTC2wqT4NagFeCkSY UN/RogSahIC99+mCZMbXq/F5q24dzu+J66bu9q/UVJR2y7JpQtqPOENL2V1C17Kbm98a PTxQ== X-Gm-Message-State: AOAM533M6Bm9fUxKkhdWoUqF62doulx67AX4itOMAWVr1aXCNV2KJbJT UzZi7oyZ3sq6eSmLl6mVJtPMcI/hH3QTCamfkidCg+xjy30= X-Google-Smtp-Source: ABdhPJz6dq2LHy7UKHQvdgVKufB8u/lKY1hoJf6DFxFrFuxzUvA6oRuXmPDHIdJO6gy+3YgkfGYQxJ9P+hxm+4r/T2s= X-Received: by 2002:a9d:74d4:: with SMTP id a20mr14754022otl.28.1624732346235; Sat, 26 Jun 2021 11:32:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Simon Glass Date: Sat, 26 Jun 2021 12:32:13 -0600 Message-ID: Subject: Re: [PATCH] serial: Add additional depencies for PL010 and PL011 drivers To: Michal Simek Cc: U-Boot Mailing List , git , AKASHI Takahiro , Mark Kettenis , Peng Fan , Sean Anderson , Stefan Roese , Vabhav Sharma , Weijie Gao Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 24 Jun 2021 at 05:57, Michal Simek wrote: > > Both of these drivers are implemented with and without DM that's why more > symbols should be handled. > The most problematic one is enabling DEBUG_UART_PL011 based on > PL01X_SERIAL(DM based) because debug console has type selection based on > it. > enum pl01x_type type = CONFIG_IS_ENABLED(DEBUG_UART_PL011) ? > TYPE_PL011 : TYPE_PL010; > > Without it pl01x_generic_setbrg() is configuring different registers. > > Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") > Signed-off-by: Michal Simek > --- > > drivers/serial/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass