All of lore.kernel.org
 help / color / mirror / Atom feed
From: sjg at google.com <sjg@google.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/3] rockchip: mkimage: force 2KB alignment for init_size
Date: Mon, 5 Jun 2017 17:31:37 -0400	[thread overview]
Message-ID: <CAPnjgZ3QZL4zwgg4kYtQdaXq=ZNWNYL6kBSb3zk+9CXgT7cjTg@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ3kV2CHD4-GLJ=-j9H24YjV6neVYn31kWv1g3UzeV=eAg@mail.gmail.com>

On 30 May 2017 at 15:32, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> The Rockchip BootROM relies on init_size being aligned to 2KB
> (see https://lists.denx.de/pipermail/u-boot/2017-May/293268.html).
>
> This pads the image to 2KB both for SD card images and SPI images
> and uses a common symbolic constant for the alignment.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> ---
>
> Changes in v3:
> - (added patch) forces the alignment/padding to 2KB for SD images, as
>   this would otherwise break the back-to-bootrom functionality
>
> Changes in v2: None
>
>  tools/rkcommon.h | 1 +
>  tools/rksd.c     | 6 +++---
>  tools/rkspi.c    | 2 +-
>  3 files changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!

  reply	other threads:[~2017-06-05 21:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 21:32 [U-Boot] [PATCH v3 0/3] rockchip: mkimage: refactor rksd/rkspi padding calculation and add dumpimage support Philipp Tomsich
2017-05-30 21:32 ` [U-Boot] [PATCH v3 1/3] rockchip: mkimage: add support for verify_header/print_header Philipp Tomsich
2017-06-05 21:31   ` sjg at google.com
2017-05-30 21:32 ` [U-Boot] [PATCH v3 2/3] rockchip: mkimage: force 2KB alignment for init_size Philipp Tomsich
2017-06-01  3:11   ` Simon Glass
2017-06-05 21:31     ` sjg at google.com [this message]
2017-05-30 21:32 ` [U-Boot] [PATCH v3 3/3] rockchip: mkimage: set init_boot_size to avoid confusing the boot ROM Philipp Tomsich
2017-06-01  3:12   ` Simon Glass
2017-06-05 21:31     ` sjg at google.com
2017-05-31  9:44 ` [U-Boot] [PATCH v3 0/3] rockchip: mkimage: refactor rksd/rkspi padding calculation and add dumpimage support Andy Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3QZL4zwgg4kYtQdaXq=ZNWNYL6kBSb3zk+9CXgT7cjTg@mail.gmail.com' \
    --to=sjg@google.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.