From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DBB0C7618E for ; Sat, 18 Mar 2023 20:23:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C1F3E85C2B; Sat, 18 Mar 2023 21:21:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="NS7A/OqR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3CA9485B2A; Sat, 18 Mar 2023 21:21:20 +0100 (CET) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F3F6085894 for ; Sat, 18 Mar 2023 21:21:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x52d.google.com with SMTP id z21so32880739edb.4 for ; Sat, 18 Mar 2023 13:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679170872; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=u2LyDCqfI6Nreqassm9g4HRqUrP9Ax/+2I81Hpw9Et8=; b=NS7A/OqRZ5nNzF+eMBjS33ojYjvNtD2y2PyCKTj5cz+RsrLuD3ZQCBy8cS65KsLzZ8 O0atMvcSTt8b36mrq2cL8Me0uwtuuDJal7k0z4xw0KOtzsJ+X+BIBBH5ZWuxkoZ/8fnQ xjNxpYY4tWz0M3c0mTFAXviFzI2iUv7WIrmAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679170872; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u2LyDCqfI6Nreqassm9g4HRqUrP9Ax/+2I81Hpw9Et8=; b=lehBZUMWPHPwTp7WoeF/hRAXAhT2aIcGKp4G51kQKTn98M4QzvjdKY/+WYWPMikIwG 03lUy20TrtNcP8y4IYcG+UBME3la68CzdZE9zI5NcuXl/ls7hambkx3CzlZi8dymHW2V rCZRuxg8G8pSlCeELcJ9YPDyvYc/5j8Su8at67ccgWQ/KP+Rc45cxSK42xehl1hSxrYD YdQ5kAmZyU2Ph9xDmoct6Hgi9Smz8rSyW1J6AGPnv1X0e2H8r7FRucfVfqtYMyUI2yGO fSVvauKK567jyIGqazHLxX017Ya3c9A//QVn87NshBmQ4EJtITSqdzal2i0aIqV6DX9x vsRQ== X-Gm-Message-State: AO0yUKXBmoFMafGmjkfronWvlVJHQ/v1DjIBIK2m9yzwMExHM3Wlqon9 jd4uMA+7SQhleehRb1x2AqUOdQhwNDX+gPW5J04t5YJnxtlAjJEz1JTerw== X-Google-Smtp-Source: AK7set/QrqrmyM8cKdogLMZrlMESPTFChi5ZkhKQ/tMx/1g1JH+Xh2dI+x5EG+lePHmRJE+maiqwZzf+bkblspJZ1AI= X-Received: by 2002:a17:906:ca11:b0:930:310:abe3 with SMTP id jt17-20020a170906ca1100b009300310abe3mr1867643ejb.6.1679170872237; Sat, 18 Mar 2023 13:21:12 -0700 (PDT) MIME-Version: 1.0 References: <20230318095549.40625-1-heinrich.schuchardt@canonical.com> In-Reply-To: <20230318095549.40625-1-heinrich.schuchardt@canonical.com> From: Simon Glass Date: Sun, 19 Mar 2023 09:20:30 +1300 Message-ID: Subject: Re: [PATCH 1/1] dm: simplify uclass_pre_remove_device To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Sat, 18 Mar 2023 at 03:56, Heinrich Schuchardt wrote: > > Remove a superfluous logical constraint. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/core/uclass.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Where possible I like to keep the happy path clear, so that we always exit with 0. I know this results in a little more code, but it does not affect the compiler output. I think it makes it easier to see when things pass or fail. > > diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c > index 1762a0796d..dce5b46fc7 100644 > --- a/drivers/core/uclass.c > +++ b/drivers/core/uclass.c > @@ -789,14 +789,10 @@ int uclass_post_probe_device(struct udevice *dev) > int uclass_pre_remove_device(struct udevice *dev) > { > struct uclass *uc; > - int ret; > > uc = dev->uclass; > - if (uc->uc_drv->pre_remove) { > - ret = uc->uc_drv->pre_remove(dev); > - if (ret) > - return ret; > - } > + if (uc->uc_drv->pre_remove) > + return uc->uc_drv->pre_remove(dev); > > return 0; > } > -- > 2.39.2 > Regards, Simon