From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50CFC433F5 for ; Tue, 19 Oct 2021 14:04:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34C5561057 for ; Tue, 19 Oct 2021 14:04:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34C5561057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 479638311B; Tue, 19 Oct 2021 16:04:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="lqza6DEo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 95BD783138; Tue, 19 Oct 2021 16:03:27 +0200 (CEST) Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2BF7682F9E for ; Tue, 19 Oct 2021 16:03:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x932.google.com with SMTP id u5so13950326uao.13 for ; Tue, 19 Oct 2021 07:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3XsCETU8o6kvgdgA9NvDMBEWvFoltw20rsm0afMFGo0=; b=lqza6DEodW+oEcBJLSqJWDBxGpfH6Ymn2VQwNNp6oqn3oglUQhxoUloTKzIhgTISWv 9jCXBbDuXr6hPtxWl8oTaTi5NrXcHng7DceYjisVhYc3vLMd4oNDDDTI1XrdwRazK02n U5va2iomOEMqw0AGglmnmoE6wsmJDRPC4GZuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3XsCETU8o6kvgdgA9NvDMBEWvFoltw20rsm0afMFGo0=; b=wdm0JgAPRK610Yb3vg3des+ZHyR+vh7MFsluGCcyzoE1uXGLzKPIgvYE9EakWgF9tq ju2bguW/Xed2lrus4CWcBKQySGTYyf0Upc55NDX54U6jRm6WnDzjFWpnpzVB7Q99DlAF 3QRfJdAGnu9guBcpSSVA833or4U22Skx00lPA114PqQHgidzjEaNyPr9OmFxN3g+apUW a2VH3Q3j5EqFm+yS0iI1s/iXL0E/O1iP1noJKybppxQsnQVxMhLoa21W9gJkWX7yKf4U qFhTAV1eDTLc7cqDpdmj8A6Lxy2FgPRjmVSiccQcpCVlEjpayrJ1iqYWHK2YeWoqQiTV B1Xg== X-Gm-Message-State: AOAM533fRc1m9eeCI2ryblFTvtWnhD3Rc2i2uqq1/aE6l9qF2LSzrhZG e3kcXMV4Onbqdhc6sX0bju0HdQ4KwJxlbfK4rIECfw== X-Google-Smtp-Source: ABdhPJyq/nspac5G+YgNbGwXRMqH0S4z/4zh+SDE2dKY1pr21WHg5RPulz9r7TaxfTAMWYExioE62F+kEl7trJF+sIE= X-Received: by 2002:ab0:4952:: with SMTP id a18mr71819uad.35.1634652198317; Tue, 19 Oct 2021 07:03:18 -0700 (PDT) MIME-Version: 1.0 References: <20211019130725.171193-1-ilias.apalodimas@linaro.org> In-Reply-To: <20211019130725.171193-1-ilias.apalodimas@linaro.org> From: Simon Glass Date: Tue, 19 Oct 2021 08:03:07 -0600 Message-ID: Subject: Re: [PATCH v4] sandbox: Remove OF_HOSTFILE To: Ilias Apalodimas Cc: Tom Rini , Patrick Delaunay , Patrice Chotard , Liviu Dudau , Thomas Fitzsimmons , Matthias Brugger , Michal Simek , =?UTF-8?Q?Pali_Roh=C3=A1r?= , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Bin Meng , Heinrich Schuchardt , Stefan Roese , Tim Harvey , Harald Seiler , Sughosh Ganu , Priyanka Jain , Vladimir Oltean , Andre Przywara , Ramon Fried , Nicolas Saenz Julienne , Peter Robinson , "Ivan T. Ivanov" , Marek Szyprowski , Zong Li , Leo Yu-Chi Liang , Sean Anderson , Rick Chen , Green Wan , T Karthik Reddy , Ashok Reddy Soma , Rasmus Villemoes , Alper Nebi Yasak , AKASHI Takahiro , Wasim Khan , Alexandru Gagniuc , Nandor Han , Pratyush Yadav , Steffen Jaeckel , Heiko Schocher , Asherah Connor , U-Boot Mailing List , U-Boot STM32 Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 19 Oct 2021 16:04:28 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Ilias, On Tue, 19 Oct 2021 at 07:07, Ilias Apalodimas wrote: > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > unique and not causing any confusions, we are better of having simpler > config options for the DTB. > > So let's replace that with the existing OF_BOARD. U-Boot would then > have only three config options for the DTB origin. > - OF_SEPARATE, build separately from U-Boot > - OF_BOARD, board specific way of providing the DTB > - OF_EMBED embedded in the u-boot binary(should not be used in production > > Signed-off-by: Ilias Apalodimas > --- > Note that this must be applied on top of > https://lore.kernel.org/u-boot/20211011210016.135929-1-ilias.apalodimas@linaro.org/ > changes since v3: > - fix xilinx platforms based on xilinx_zynq_virt_defconfig > changes since v2: > - Rebased on top of the updated OF_BOARD patchset > Changes since v1: > - Added internal error value on board_fdt_blob_setup(). Arguably > we can just check against NULL and simplify this even more if we > don't care about the errno > - OF_BOARD is now default for sandbox builds > Makefile | 6 ++--- > arch/arm/mach-stm32mp/boot_params.c | 3 ++- > arch/sandbox/cpu/cpu.c | 27 +++++++++++++-------- > arch/sandbox/include/asm/u-boot-sandbox.h | 8 ------ > board/AndesTech/ax25-ae350/ax25-ae350.c | 2 ++ > board/Marvell/octeontx/board-fdt.c | 3 ++- > board/Marvell/octeontx2/board-fdt.c | 3 ++- > board/Marvell/octeontx2/board.c | 3 ++- > board/armltd/vexpress64/vexpress64.c | 7 ++++-- > board/broadcom/bcmstb/bcmstb.c | 3 ++- > board/emulation/qemu-arm/qemu-arm.c | 3 ++- > board/emulation/qemu-ppce500/qemu-ppce500.c | 3 ++- > board/emulation/qemu-riscv/qemu-riscv.c | 3 ++- > board/highbank/highbank.c | 3 ++- > board/raspberrypi/rpi/rpi.c | 8 ++++-- > board/sifive/unleashed/unleashed.c | 3 ++- > board/sifive/unmatched/unmatched.c | 3 ++- > board/socrates/socrates.c | 4 ++- > board/xen/xenguest_arm64/xenguest_arm64.c | 7 ++++-- > board/xilinx/common/board.c | 3 ++- > configs/sandbox64_defconfig | 1 - > configs/sandbox_defconfig | 1 - > configs/sandbox_flattree_defconfig | 1 - > configs/sandbox_noinst_defconfig | 1 - > configs/sandbox_spl_defconfig | 1 - > configs/tools-only_defconfig | 1 - > doc/develop/devicetree/control.rst | 7 +++--- > dts/Kconfig | 10 +------- > include/fdtdec.h | 4 ++- > lib/fdtdec.c | 14 +++++------ > scripts/Makefile.spl | 4 +-- > 31 files changed, 81 insertions(+), 69 deletions(-) > For some reason this still does not apply for me on -master. Can you please confirm the hash you are using? Regards, Simon