From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06623C4338F for ; Wed, 28 Jul 2021 02:46:34 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFEFC60EBB for ; Wed, 28 Jul 2021 02:46:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DFEFC60EBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B29F482AE5; Wed, 28 Jul 2021 04:46:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LizEY/+W"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EA24482B36; Wed, 28 Jul 2021 04:46:28 +0200 (CEST) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B39DD829A6 for ; Wed, 28 Jul 2021 04:46:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x432.google.com with SMTP id c16so619992wrp.13 for ; Tue, 27 Jul 2021 19:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iWb2zsU6hGeJliIe9sisxON5KP5CV70fu6JJEUPVYHY=; b=LizEY/+WPU0MwsvWEHb1IInSuE//qdGGzstW49YVBhgj1sYGyrZGJEraXdHJnWZ9J6 PBpGT1mIiaAQeMIYwvZ6rJp6EHvlWfy0c5HZu0XjeA8lVIO1os3tgqJodi576XV+aG4K UjHoqQIMfLRWT0Gc/f1IyTv4+Oo4rCmoQP5XU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iWb2zsU6hGeJliIe9sisxON5KP5CV70fu6JJEUPVYHY=; b=HlisawbRtVR/9aRCQSHyvKPADjeTdtzVwSq3ESJmeNaYRlcvhoFg8YzQEUXkdF4KMv YBml/+OKQFD/mgv5+ASLe6gd2VIzHFpueycy2XQCZ3OyMgFcnNQ5k0njjYMwvnxOzv5B 0PSX+sOKL5V3NDJSWS/F9P8KPNEuvocXmtTXCkqTD9mouc0KY0lO0CQVhmpgmtBPVuY/ Gld72yNNlhUmp8tjSciLZFCUL+cJ5ekKl4wv28HCQ9ZHb4UTqWMVzWOZ2rXtP+MZzRV2 baTF9MjFwj30HbIT69YWJZ6zgbvtaAyjTNI8CP5dWbxrtU9pD7qHAbWz2hcyLsekCs+Y rcBw== X-Gm-Message-State: AOAM5337jg/5lgdjzw5Fhby+/mKN4xRQ6ecC2fmOeDIIexLZ36JtLYtK oSI0NWumUetyVYEMi5uITeEaMgQioWAAxy2q4MEIvw== X-Google-Smtp-Source: ABdhPJyqsnTqr9DA9ee2EvPgM4XPGjtfqNR38a3tfpYOUPACLPtjezXNxkYlLlxm6SIM3O4WEeEvwkzO3hJKAlAs4e8= X-Received: by 2002:adf:e409:: with SMTP id g9mr28840646wrm.66.1627440384968; Tue, 27 Jul 2021 19:46:24 -0700 (PDT) MIME-Version: 1.0 References: <20210725165416.470735-1-sjg@chromium.org> <20210725165416.470735-2-sjg@chromium.org> In-Reply-To: From: Simon Glass Date: Tue, 27 Jul 2021 20:46:13 -0600 Message-ID: Subject: Re: [PATCH v2 2/3] arm: Add an __image_copy_start symbol for ARMv8 To: Tim Harvey Cc: U-Boot Mailing List , Albert Aribaud , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tim, On Mon, 26 Jul 2021 at 12:20, Tim Harvey wrote: > > On Sun, Jul 25, 2021 at 9:54 AM Simon Glass wrote: > > > > This symbol is needed for binman to locate the start of the image. Add it. > > > > Note: the existing line to bring in the .__image_copy_start symbol does > > not appear to do anything. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: > > - Add new patch to add an __image_copy_start symbol for ARMv8 > > > > arch/arm/cpu/armv8/u-boot-spl.lds | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/cpu/armv8/u-boot-spl.lds b/arch/arm/cpu/armv8/u-boot-spl.lds > > index 9edb662b094..2827a07590d 100644 > > --- a/arch/arm/cpu/armv8/u-boot-spl.lds > > +++ b/arch/arm/cpu/armv8/u-boot-spl.lds > > @@ -22,6 +22,7 @@ ENTRY(_start) > > SECTIONS > > { > > .text : { > > + __image_copy_start = .; > > . = ALIGN(8); > > *(.__image_copy_start) > > CPUDIR/start.o (.text*) > > -- > > 2.32.0.432.gabb21c7263-goog > > > > Sould the '*(.__image_copy_start)' be removed? > > I'll admit that I'm not very knowledgable when it comes to linker > files. I did verify removing it boots fine. I did look around for symbols in that section and could not find any, but I'm not 100% sure. Regards, SImon