From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B718DC433F5 for ; Thu, 7 Oct 2021 02:19:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5EDE61215 for ; Thu, 7 Oct 2021 02:19:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B5EDE61215 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1143083424; Thu, 7 Oct 2021 04:19:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="BUP7zFVq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 738808331F; Thu, 7 Oct 2021 04:19:05 +0200 (CEST) Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7032C8329E for ; Thu, 7 Oct 2021 04:18:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92d.google.com with SMTP id j13so3226680uaq.0 for ; Wed, 06 Oct 2021 19:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oxkZBdaz4oYoMAfzPVl+Tg0eNv7gMO7nL6rmDL2oT24=; b=BUP7zFVqBzMIpk4lnAJog4beaFxjSxxEagEIEQpqySBNg6nNf4QEYQM5iyhicl46Td VSUzxkS3EUCdGeqtCkZrl9UqbwJHyC4TZbxNncWBq0DjEUKdHRjRgGcF8PpDV0QJhvYS InAS9Qj8Udt9XzTRJN998lwsbu87rXoC+cvfw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oxkZBdaz4oYoMAfzPVl+Tg0eNv7gMO7nL6rmDL2oT24=; b=DKXOVTyrTVsCU/rQm5ItNspxKVfhoKgFk004CKGoB/wgShbBSCG+aC+A9Qjq37mpkj nAyx5iBc/C3OYuSxX5OCi+V86/yLieH6TrcihTJttYMgiy8Q30YF8vOGWo9sGS79i/U9 Jroz/ygGmw07+O4nLSGD8+Vd18txoLa7xFAagFKGqXE+Xb/UNJj9mTeHQn0QOkbBgJLU KSasQWZbHH/qGgyVPCbk12OjifUFNbKZLUy+4RLw9uddbLJPa59zitrRy/3e3q6bZ95X F09lj5rz1rlPYDA/tgsfqlk8PcYuEQ4iPMp2pBV/YPQQfGQXeksiUM/puq5KUKIznv37 vWYA== X-Gm-Message-State: AOAM532Q7Wz+0wHnOje5j3AUjxwBqiS60yXVyM397NYGSW8yYDAY0CkL fg4IZU9X2MaTSH4SjwXRtVs05YoGXqFvu63qEFFIiFT2qdw= X-Google-Smtp-Source: ABdhPJyt7rziABKLTWEaIZHUqKRJ7bbWJrTREyxZj6hyfMfj/jZydBFHmevRvQ1Exq6SbD1jI5/P//1WJkD5z0Hi2Us= X-Received: by 2002:a05:6130:321:: with SMTP id ay33mr2318845uab.140.1633573135949; Wed, 06 Oct 2021 19:18:55 -0700 (PDT) MIME-Version: 1.0 References: <20211006212757.464740-1-marcel@ziswiler.com> <20211006212757.464740-5-marcel@ziswiler.com> In-Reply-To: <20211006212757.464740-5-marcel@ziswiler.com> From: Simon Glass Date: Wed, 6 Oct 2021 20:18:44 -0600 Message-ID: Subject: Re: [PATCH v4 04/10] verdin-imx8mm: switch to use binman to pack images To: Marcel Ziswiler Cc: U-Boot Mailing List , Stefano Babic , Heiko Thiery , Fabio Estevam , Frieder Schrempf , Marcel Ziswiler , Heiko Schocher , Igor Opaniuk , Ilko Iliev , Jaehoon Chung , Jagan Teki , Marek Vasut , Max Krummenacher , "NXP i.MX U-Boot Team" , Peng Fan , Teresa Remmet Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Marcel, On Wed, 6 Oct 2021 at 15:28, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Use binman to pack images. > > Signed-off-by: Marcel Ziswiler > Reviewed-by: Heiko Thiery > Reviewed-by: Fabio Estevam > Reviewed-by: Heiko Schocher > > --- > > Changes in v4: > - Add Heiko Schocher's reviewed-by tag. > - Fix copyright periods. > > Changes in v3: > - Case fold hex string. > - Revert binman part of imx8mm-verdin-u-boot.dtsi to a plain copy from > imx8mm-evk and postpone further improvements to after migrating to a > common binman config as agreed with Frieder and Simon. > > Changes in v2: > - Explicitly pass filename to binman when generating binaries as > suggested by Heiko. > - Use proper intermediate binary u-boot-spl-ddr.bin for imximage as > pointed out by Heiko. > > arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 124 ++++++++++++++++++++++- > arch/arm/mach-imx/imx8m/Kconfig | 1 + > board/toradex/verdin-imx8mm/imximage.cfg | 11 +- > configs/verdin-imx8mm_defconfig | 2 +- > doc/board/toradex/verdin-imx8mm.rst | 53 +++++----- > 5 files changed, 157 insertions(+), 34 deletions(-) Nice clean-up! Reviewed-by: Simon Glass Option below. > > diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > index a97626fa0c1..0c65070cd5f 100644 > --- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > @@ -1,11 +1,15 @@ > // SPDX-License-Identifier: GPL-2.0+ OR MIT > /* > - * Copyright 2020 Toradex > + * Copyright 2020-2021 Toradex > */ > > #include "imx8mm-u-boot.dtsi" > > / { > + binman: binman { > + multiple-images; > + }; > + > firmware { > optee { > compatible = "linaro,optee-tz"; > @@ -91,3 +95,121 @@ > &wdog1 { > u-boot,dm-spl; > }; > + > +&binman { > + u-boot-spl-ddr { > + filename = "u-boot-spl-ddr.bin"; > + pad-byte = <0xff>; > + align-size = <4>; > + align = <4>; > + > + u-boot-spl { > + align-end = <4>; > + }; > + > + blob_1: blob-ext@1 { > + filename = "lpddr4_pmu_train_1d_imem.bin"; > + size = <0x8000>; > + }; You can use the 'type' if you like, so you don't need the @: blob_1: 1d-imem { type = "blob-ext"; filename = "..."; ... Regards, Simon