From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 12 Apr 2018 10:42:08 -0600 Subject: [U-Boot] [PATCH v2 10/18] bios: vesa: Guard setting vesa mode with CONFIG_FRAMEBUFFER_SET_VESA_MODE In-Reply-To: <1523509343-18123-11-git-send-email-bmeng.cn@gmail.com> References: <1523509343-18123-1-git-send-email-bmeng.cn@gmail.com> <1523509343-18123-11-git-send-email-bmeng.cn@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bin, On 11 April 2018 at 23:02, Bin Meng wrote: > If CONFIG_FRAMEBUFFER_SET_VESA_MODE is not set, don't switch > graphics card to VESA mode. This applies to both native mode > and emulator mode of running the VGA BIOS. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/lib/bios.c | 4 ++++ > drivers/bios_emulator/atibios.c | 4 ++++ > 2 files changed, 8 insertions(+) Could this use if() instead of #ifdef ? Reviewed-by: Simon Glass