From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 1 Aug 2016 12:22:29 -0600 Subject: [U-Boot] [PATCH v2 08/11] buildman: Avoid overwriting existing toolchain entries In-Reply-To: <20160728032845.GD5926@bill-the-cat> References: <1469673188-15834-1-git-send-email-sjg@chromium.org> <1469673188-15834-9-git-send-email-sjg@chromium.org> <20160728032845.GD5926@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27 July 2016 at 21:28, Tom Rini wrote: > On Wed, Jul 27, 2016 at 08:33:05PM -0600, Simon Glass wrote: > >> The current code for setting up the toolchain config always writes the new >> paths to an item called 'toolchain'. This means that it will overwrite any >> existing toolchain item with the same name. In practice, this means that: >> >> buildman --fetch-arch all >> >> will fetch all toolchains, but only the path of the final one will be added >> to the config. This normally works out OK, since most toolchains are the >> same version (e.g. gcc 4.9) and will be found on the same path. But it is >> not correct and toolchains for archs which don't use the same version will >> not function as expected. >> >> Adjust the code to use a complete glob of the toolchain path. >> >> Signed-off-by: Simon Glass > > Reviewed-by: Tom Rini > > -- > Tom Applied to u-boot-dm