All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] EXYNOS: SPI: Support SPI_PREAMBLE mode
Date: Mon, 6 May 2013 08:37:25 -0600	[thread overview]
Message-ID: <CAPnjgZ3Xmv0iQj42mSebCwCBecw3JsBgibDxrhKTqiwdRfA1HA@mail.gmail.com> (raw)
In-Reply-To: <CANy1buL7pxzB9DfDHMV8ZTwbMohF1ai6GcB=h69nUUpxNq4Mgw@mail.gmail.com>

HI Vadim,

On Thu, May 2, 2013 at 11:12 PM, Vadim Bendebury <vbendeb@chromium.org> wrote:
> [the original patch removed, re-sending from a registered address]
>
> So, I spent some more time debugging a system which requires this
> patch: a system, where on a SPI interface a response to a command
> could come way later then the command data transmission completes.
>
> The original patch was trying to address many corner cases, but come
> to think of it, in this situation the slave does not care about extra
> data sent on the transmit interface, as otherwise there is no clock
> and no data could be transferred from the slave.
>
> Then, for this SPI interface we do not need to set the counter of
> clocks, and do not need to keep adding more clocks if the data has not
> been received yet, the clocks could be just free running. And then the
> patch becomes much simpler, what do you think:

Does this deal with the performance problems that the old driver code
had? There were a number of other patches sent upstream by Rajeshwari
also. I wonder if it might be easier to do your improvement as a
separate patch on top of those instead. Then it can be considered on
its merits.

Regards,
Simon

  reply	other threads:[~2013-05-06 14:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03  4:53 [U-Boot] [PATCH 2/2] EXYNOS: SPI: Support SPI_PREAMBLE mode Vadim Bendebury
2013-05-03  5:12 ` Vadim Bendebury
2013-05-06 14:37   ` Simon Glass [this message]
2013-05-06 16:01     ` Vadim Bendebury
2013-05-11 21:38       ` Simon Glass
  -- strict thread matches above, loose matches on Subject: below --
2013-03-22  6:29 [U-Boot] [PATCH 0/2] SPI: Enable SPI_PREAMBLE Mode Rajeshwari Shinde
2013-03-22  6:29 ` [U-Boot] [PATCH 2/2] EXYNOS: SPI: Support SPI_PREAMBLE mode Rajeshwari Shinde
2013-05-03  1:28   ` Vadim Bendebury
2013-05-06 12:06     ` Simon Glass
2013-05-11 14:41     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3Xmv0iQj42mSebCwCBecw3JsBgibDxrhKTqiwdRfA1HA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.