From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 25 Oct 2012 11:11:49 -0700 Subject: [U-Boot] [PATCH V3 2/5] ARM: enhance u-boot.lds to detect over-sized SPL In-Reply-To: <20121022175212.GB11518@bill-the-cat> References: <1350922776-30909-1-git-send-email-swarren@wwwdotorg.org> <1350922776-30909-2-git-send-email-swarren@wwwdotorg.org> <20121022175212.GB11518@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Oct 22, 2012 at 10:52 AM, Tom Rini wrote: > On Mon, Oct 22, 2012 at 10:19:33AM -0600, Stephen Warren wrote: > >> From: Stephen Warren >> >> Add an ASSERT() to u-boot.lds to detect an SPL that doesn't fit within >> SPL_TEXT_BASE..SPL_MAX_SIZE. >> >> Different .lds files implement this check in two possible ways: >> 1) An ASSERT() like this >> 2) Defining a MEMORY region of size SPL_MAX_SIZE, and re-directing all >> linker output into that region. Since u-boot.lds is used for both >> SPL and main U-Boot, this would entail only sometimes defining a >> MEMORY region, and only sometimes performing that redirection, and >> hence option (1) was deemed much simpler, and hence implemented. >> >> Note that this causes build failures at least for NVIDIA Tegra Seaboard >> and Ventana. However, these are legitimate; the SPL doesn't fit within >> the required space, and this does cause runtime issues. >> >> Signed-off-by: Stephen Warren >> Acked-by: Simon Glass >> Acked-by: Allen Martin I tested this series on seaboard. Tested-by: Simon Glass > > This isn't quite what I envisoned at first (see > arch/arm/cpu/armv7/omap-common/u-boot-spl.lds) but I think for the > generic linker script, this is the least instrusive method. > > Acked-by: Tom Rini > > And since parts 1 and 2 are generic code, I've assigned them to Albert > in patchwork. It's his call if he wants to take them or have them all > come via the tegra tree. > > -- > Tom > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >