From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Fri, 22 Aug 2014 19:47:36 -0600 Subject: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1 In-Reply-To: <20140822220330.GA24037@mithrandir> References: <1408346196-30419-1-git-send-email-thierry.reding@gmail.com> <1408346196-30419-24-git-send-email-thierry.reding@gmail.com> <53F4EE37.3020003@wwwdotorg.org> <20140822120943.GA15686@ulmo> <20140822194030.GB31506@ulmo> <20140822220330.GA24037@mithrandir> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Thierry, On 22 August 2014 16:03, Thierry Reding wrote: > On Fri, Aug 22, 2014 at 02:12:19PM -0600, Simon Glass wrote: >> On 22 August 2014 13:40, Thierry Reding wrote: > [...] >> > I've opted instead to provide an somewhat higher-level API that users >> > can call to set voltages on the regulators and enable them. >> >> But then this should use/extend the pmic interface I think, and not >> create a parallel one. > > It's not a parallel framework. And it's not anything out of the ordinary > either. There's a whole bunch of drivers in drivers/power that do the > very same thing. > > And I'm not sure something like Linux' regulator framework is something > that we really need in U-Boot. The code in question is usually run in > some board-specific initialization file, not from some generic driver > that would need to be used in conjunction with potentially very many > PMICs. OK, well I suggest first take a look at pmic_tps65090.c and convince yourself that you can't plumb your pmic in in a similar way. It's up to you. Regards, Simon