From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9268DEB64D9 for ; Sun, 2 Jul 2023 15:44:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8E346863BA; Sun, 2 Jul 2023 17:44:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="YpxcxzzD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4287F863C1; Sun, 2 Jul 2023 17:44:56 +0200 (CEST) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9F32A863B8 for ; Sun, 2 Jul 2023 17:44:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fbc244d307so40332395e9.1 for ; Sun, 02 Jul 2023 08:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1688312693; x=1690904693; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VDi/OGv+u0AY32REkafBrrbBlZOAG5a8W02Pnu7ZTV8=; b=YpxcxzzDCq6EluK6aoKbEjVi7uQDSiIl39TmHPvkCMzbfvrdvtd6Inmh1pD2/WVY5t v2+5wJYbW3EoLRDVputB8f673wMBA1c9wmKjsqvea3C225Hnh9yahHxCp8U/HrkGks1X d0hCLmmTOy/VEFnv0D3u8ytmE+sY0KiA9tZHk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688312693; x=1690904693; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VDi/OGv+u0AY32REkafBrrbBlZOAG5a8W02Pnu7ZTV8=; b=dU8gZP/sFoVQ6h2ikjnktABOMeAg+hJyRoEy/Y0XyKq8S5Tf8byhXPRVx6TzfwNoU6 JozJz1HUMugBSef2i6eWVXNI1YduzEowGcccyGyLB1YwtLuhnkNejfb2NMVXlNbvdkak 97PJT+a2vtlUxtFiLVtCzluhnH9PEj14skNWhIQkNMEH3FeLb04ef4DR/H2vUdLc5AS3 I5BejsqWosEWCZQsbnx7L1h9MPZRePMPlf20sGSAxZ612WT1v9Shq4I1OrYfdWIdObQY Y2QqTyvUSBCO0/4QMeJuq7XygSpqeL+mbFYDABnuZEJhBot7qVywkicW3ZH07ekQzR0m zFGQ== X-Gm-Message-State: AC+VfDxHS3ah7sO2O45KK7LY/vxHsHG3lCC3MqeHw/6iSFNHA0n8NHeb J9qP85gI+zkSSHn7ziBUBejRhmGK4XdmQ1PBIhmT5Q== X-Google-Smtp-Source: ACHHUZ5Xu8UQ8DlfAEa34e0eUFJ/NQM2SyFIlVLUr5Qn2/mFufj9oHDvr+t6Ro/OE9a01Kmxb5gj52sSfkVlvQsgwOk= X-Received: by 2002:a7b:c397:0:b0:3f9:871:c2da with SMTP id s23-20020a7bc397000000b003f90871c2damr7170015wmj.40.1688312692895; Sun, 02 Jul 2023 08:44:52 -0700 (PDT) MIME-Version: 1.0 References: <20230606134856.GA1871110@bill-the-cat> <20230616152817.319869-1-abdellatif.elkhlifi@arm.com> <20230616152817.319869-5-abdellatif.elkhlifi@arm.com> <20230630124916.GA131777@e130802.arm.com> In-Reply-To: <20230630124916.GA131777@e130802.arm.com> From: Simon Glass Date: Sun, 2 Jul 2023 16:44:41 +0100 Message-ID: Subject: Re: [PATCH v13 04/10] arm_ffa: introduce Arm FF-A support To: Abdellatif El Khlifi Cc: u-boot@lists.denx.de, nd@arm.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Abdellatif, On Fri, 30 Jun 2023 at 13:49, Abdellatif El Khlifi wrote: > > Hi Simon, > > On Tue, Jun 20, 2023 at 11:27:20AM +0100, Simon Glass wrote: > > wrote: > > > > > > Add Arm FF-A support implementing Arm Firmware Framework for Armv8-A v1.0 > > > > > > The Firmware Framework for Arm A-profile processors (FF-A v1.0) [1] > > > describes interfaces (ABIs) that standardize communication > > > between the Secure World and Normal World leveraging TrustZone > > > technology. > > > > > > This driver uses 64-bit registers as per SMCCCv1.2 spec and comes > > > on top of the SMCCC layer. The driver provides the FF-A ABIs needed for > > > querying the FF-A framework from the secure world. > > > > > > The driver uses SMC32 calling convention which means using the first > > > 32-bit data of the Xn registers. > > > > > > All supported ABIs come with their 32-bit version except FFA_RXTX_MAP > > > which has 64-bit version supported. > > > > > > Both 32-bit and 64-bit direct messaging are supported which allows both > > > 32-bit and 64-bit clients to use the FF-A bus. > > > > > > FF-A is a discoverable bus and similar to architecture features. > > > FF-A bus is discovered using ARM_SMCCC_FEATURES mechanism performed > > > by the PSCI driver. > > > > > > Clients are able to probe then use the FF-A bus by calling the DM class > > > searching APIs (e.g: uclass_first_device). > > > > > > The Secure World is considered as one entity to communicate with > > > using the FF-A bus. FF-A communication is handled by one device and > > > one instance (the bus). This FF-A driver takes care of all the > > > interactions between Normal world and Secure World. > > > > > > The driver exports its operations to be used by upper layers. > > > > > > Exported operations: > > > > > > - ffa_partition_info_get > > > - ffa_sync_send_receive > > > - ffa_rxtx_unmap > > > > > > Generic FF-A methods are implemented in the Uclass (arm-ffa-uclass.c). > > > Arm specific methods are implemented in the Arm driver (arm-ffa.c). > > > > > > For more details please refer to the driver documentation [2]. > > > > > > [1]: https://developer.arm.com/documentation/den0077/latest/ > > > [2]: doc/arch/arm64.ffa.rst > > > > > > Signed-off-by: Abdellatif El Khlifi > > > Cc: Tom Rini > > > Cc: Simon Glass > > > Cc: Ilias Apalodimas > > > Cc: Jens Wiklander > > > Cc: Heinrich Schuchardt > > > > > > --- > > > > > > Changelog: > > > =============== > > > > > > v13: > > > > > > * doc minor change: specify in the readme that the user > > > should call ffa_rxtx_unmap() driver operation to unmap > > > the RX/TX buffers on demand. > > Are you happy with this commit please ? May I add a Reviewed-by ? Sorry I think I did something wrong on the previous reply. Reviewed-by: Simon Glass Regards, Simon