From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85C74C433EF for ; Mon, 13 Dec 2021 12:53:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C99208378D; Mon, 13 Dec 2021 13:52:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="S6vkY+6o"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D18FE8377E; Mon, 13 Dec 2021 13:52:12 +0100 (CET) Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D2D3C83776 for ; Mon, 13 Dec 2021 13:52:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92a.google.com with SMTP id n9so9961579uaq.10 for ; Mon, 13 Dec 2021 04:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Gr3u10SpBHWtVh+Suu6dXTchkL8d5tPjQl502a+X/E=; b=S6vkY+6oUVXGHPPcBHDl2lGLRoc7GgibJjfgWZkiWRIkj3cU02AxUi/h1zn/KVataT Yip9jPyL01BEWE/t1PuYsfML4+4qaBUkM+oGvnftVKb5tRpqxk1TtlMtVh0kH16GOTqb 5KffWzHmA9KlMCMWZSqabnk0u7OL9f8h7Wz5Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Gr3u10SpBHWtVh+Suu6dXTchkL8d5tPjQl502a+X/E=; b=rKWEmTVY1+JwbaB7vZZW0FHSzUFhsyxSXlTwhczn51A6WtXXSZI8YRWyApy8muFUDF hjOZCB2hsc8w+N/oNTC1HpouPH8ugG1wVxIJ7vSXOOL+lAo2PXq4JajwB1GmJA1ekhd3 8xda1q5fPD0hPKH4xa6RFuoWW5dL2BPoGD8SUyrVW/TXUAqWlXHuBKY9Dag2pYOecSHy NLOpUtvzKweENkz7lDgGEfINCLgEDOP7pTQM2SvKX562UFg9DjaZivpoYMnPzsuGhZtK oz4GBjLlmiSPPbdKlQs1ksTnUC+zFyHF3tXvJ44ab54Q091YEQ7HEsTL7tipFYKj0g+X eNXw== X-Gm-Message-State: AOAM53225IY13z+9rFMM8KARrxJnk6D1XXKilPv7BYSBCkiprro9C9Y4 S+1us/tHvWdxfI7Xclj5TKbU+sTy7aAHdEQncrLBnQ== X-Google-Smtp-Source: ABdhPJxOj1nJYeLkpAQ3JglamAa4Jw6GOzkEtFb9xYKo4co/9Q8Qwo2kXd3qXaDWetiUGNhbx+FmU69A5AWgUIOGJTE= X-Received: by 2002:ab0:2983:: with SMTP id u3mr40382975uap.35.1639399921161; Mon, 13 Dec 2021 04:52:01 -0800 (PST) MIME-Version: 1.0 References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-20-takahiro.akashi@linaro.org> In-Reply-To: <20211210064947.73361-20-takahiro.akashi@linaro.org> From: Simon Glass Date: Mon, 13 Dec 2021 05:51:50 -0700 Message-ID: Subject: Re: [RFC v2 19/20] efi_loader: disk: not create BLK device for BLK(IF_TYPE_EFI) devices To: AKASHI Takahiro Cc: xypron.glpk@gmx.de, agraf@csgraf.de, ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 9 Dec 2021 at 23:58, AKASHI Takahiro wrote: > > When we create an efi_disk device with an UEFI application using driver > binding protocol, the 'efi_driver' framework tries to create > a corresponding block device(UCLASS_BLK/IF_TYPE_EFI). This will lead to > calling a PROBE callback, efi_disk_probe(). > In this case, however, we don't need to create another "efi_disk" device > as we already have this device instance. > > So we should avoid recursively invoke further processing in the callback > function. > > Signed-off-by: AKASHI Takahiro > --- > lib/efi_loader/efi_disk.c | 22 +++++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) > Reviewed-by: Simon Glass