From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Tue, 25 Sep 2018 12:39:53 -0700 Subject: [U-Boot] [PATCH v4 6/6] common: Generic loader for file system In-Reply-To: <1537858961.11241.7.camel@intel.com> References: <1530865683-23207-1-git-send-email-tien.fong.chee@intel.com> <30e0c183-12d9-667d-3e51-caa986b399ff@xilinx.com> <1532500298.9671.24.camel@intel.com> <037207e4-bff7-8b97-7f06-74ddabe7c237@xilinx.com> <20180725160316.GW11755@bill-the-cat> <780b5bee-4448-793b-aaa9-fc5fe2ba1d3d@xilinx.com> <1532680844.10087.21.camel@intel.com> <02ac3ca3-ccf7-3ae6-ed37-78614064a743@xilinx.com> <81153570-2a0c-603b-c2a9-3fcf5831ec8b@xilinx.com> <1537504974.10097.3.camel@intel.com> <1537858961.11241.7.camel@intel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 25 September 2018 at 01:02, Chee, Tien Fong wrote: > On Thu, 2018-09-20 at 21:42 -0700, Chee, Tien Fong wrote: >> > > If everybody agree with current framework, then the next version i will > include the fixes: > 1. Adding DM_FLAG_PRE_RELOC, this would allow runtime to choose the > right fs_loader if the chosen node u-boot, fs-loader is not defined. > > 2. Let driver model handles all memory allocation > > 3. Using local variable instead of messy casts. Sounds good. Can you please give an example of this? If you just mean within a function, that's fine. We try to avoid static variables with driver model. Regards, Simon