All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 4/6] stdio: Update to use compiler for Kconfig checks
Date: Tue, 4 Aug 2020 07:37:02 -0600	[thread overview]
Message-ID: <CAPnjgZ3hFJGDen2btpfJeeh=mdyOwLWMtO=PVwnKty7iYtB1sQ@mail.gmail.com> (raw)
In-Reply-To: <20200804021829.GX6965@bill-the-cat>

Hi Tom,

On Mon, 3 Aug 2020 at 20:18, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Aug 03, 2020 at 06:57:05PM -0400, Tom Rini wrote:
> > On Fri, Jul 17, 2020 at 09:03:17PM -0600, Simon Glass wrote:
> >
> > > Drop use of the preprocessor where possible.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > [snip]
> > > +   if (IS_ENABLED(CONFIG_DM_VIDEO)) {
> > > +           /*
> > > +            * If the console setting is not in environment variables then
> > > +            * console_init_r() will not be calling iomux_doenv() (which
> > > +            * calls search_device()). So we will not dynamically add
> > > +            * devices by calling stdio_probe_device().
> > > +            *
> > > +            * So just probe all video devices now so that whichever one is
> > > +            * required will be available.
> > > +            */
> > > +           struct udevice *vdev;
> > > +           int ret;
> > > +
> > > +           if (!IS_ENABLED(CONFIG_SYS_CONSOLE_IS_IN_ENV)) {
> > > +                   for (ret = uclass_first_device(UCLASS_VIDEO, &vdev);
> > > +                        vdev;
> > > +                        ret = uclass_next_device(&vdev))
> > > +                           ;
> > > +                   if (ret)
> > > +                           printf("%s: Video device failed (ret=%d)\n",
> > > +                                  __func__, ret);
> > > +           }
> > > +           if (IS_ENABLED(CONFIG_SPLASH_SCREEN) &&
> > > +               IS_ENABLED(CONFIG_CMD_BMP))
> > > +                   splash_display();
> >
> > We can't do this yet because CONFIG_SPLASH_SCREEN isn't migrated so the
> > test fails and we drop the bmp logo.  I got this run-time tested and
> > confirmed on colibri imx6 by my colleague Matt Porter.  So I'm holding
> > off on _this_ patch (and then the style clean up patch) until I can push
> > SPLASH_SCREEN migration through.
>
> This is also an issue for "stdio: Tidy up use of
> CONFIG_SYS_DEVICE_NULLDEV" as well, so I'm going to put aside the whole
> series until I can convert SPLASH_SCREEN.

OK, let me know if you'd like me to do something here. My patch 2 was
supposed to migrate CONFIG_SPLASH_SCREEN, etc. Did that not work?

Regards,
SImon

  reply	other threads:[~2020-08-04 13:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18  3:03 [PATCH 0/6] stdio: Clean up stdio.c Simon Glass
2020-07-18  3:03 ` [PATCH 1/6] Convert CONFIG_SYS_DEVICE_NULLDEV to Kconfig Simon Glass
2020-07-18 18:04   ` Ovidiu Panait
2020-07-26 14:54     ` Simon Glass
2020-07-18  3:03 ` [PATCH 2/6] stdio: Tidy up use of CONFIG_SYS_DEVICE_NULLDEV Simon Glass
2020-07-18  3:03 ` [PATCH 3/6] stdio: Drop #ifdefs in the header file Simon Glass
2020-07-18  3:03 ` [PATCH 4/6] stdio: Update to use compiler for Kconfig checks Simon Glass
2020-08-03 22:57   ` Tom Rini
2020-08-04  2:18     ` Tom Rini
2020-08-04 13:37       ` Simon Glass [this message]
2020-08-04 13:46         ` Tom Rini
2020-08-04 14:05           ` Simon Glass
2020-07-18  3:03 ` [PATCH 5/6] stdio: Drop brackets around &devs.list Simon Glass
2020-07-18  3:03 ` [PATCH 6/6] stdio: Tidy up the coding style Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3hFJGDen2btpfJeeh=mdyOwLWMtO=PVwnKty7iYtB1sQ@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.