From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0E2DC433EF for ; Sat, 26 Feb 2022 18:37:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DEA7D83BF8; Sat, 26 Feb 2022 19:37:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="d8fsZcLu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0169383073; Sat, 26 Feb 2022 19:36:58 +0100 (CET) Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5BF8583381 for ; Sat, 26 Feb 2022 19:36:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa31.google.com with SMTP id j9so3227265vkj.1 for ; Sat, 26 Feb 2022 10:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PXToWgnMZLQYZrjJPhXDJ3zc9z1om7YM3ckxFkiw/us=; b=d8fsZcLungOCnBI9VMwsP72GGkBsRJayDIaTp0cXZpYLWE5QHu77859rYoKFL48ybn MdVdOfkk+AwgiOYEpEY+YNuqmUArjltraOb+O7ltY+aVxgiadGsT7tavnkd9V0/IQbA4 bZgLxoE7RK9BbJO3FghqQ7uwr9VZrd9TjSY+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PXToWgnMZLQYZrjJPhXDJ3zc9z1om7YM3ckxFkiw/us=; b=r6HlLyBtDw2WMpUh6GGgLTLML/DUBYO7IWTYBWfxvtnys9ZNV0LNf/joFEJ4jU91ko M1ZvCIdL/IkiDwJp9mXYhYQdndF/aJvsfb9mc9AlHuHTP0laNRggM+y/g2MmCnw60e3J hfVQswuPWMrq/cJwceSc5NnOoav8TqvR6WYluDN8pq2kj5Qc2CyGKRSj05ubmvKhI6LO TEmCtHCJFqMg/4WDgP36CQ+qiebDaJHKpjiXxE5+k1BRAqx2fV7JYmVoekJSyxZUgytC ji6MiVi72ahNY0vdsAfkVTXiFv+LDa7DM7SlLJ3wVUzaCFdsAaZR8NfZdcPuVWcLDvGB azZw== X-Gm-Message-State: AOAM5300gwg7l+EVmHWgRdTAoLN75SYX8dN5J6GqEFHSgyJ2ixvt7ktN qi+rXaIi9X+w+UoxCDek0dM45BMC673KXSGe99bQH+Os5Cw= X-Google-Smtp-Source: ABdhPJxjREsrUrkQSPbdKwtA+iUq36JiVbTCdlIk5S9fugVX6JTvAQApCr0JOBGz5b8irUxzxr4XuzRqtcRyNVrYEno= X-Received: by 2002:a05:6122:2092:b0:331:fb3a:3eee with SMTP id i18-20020a056122209200b00331fb3a3eeemr5714861vkd.16.1645900611792; Sat, 26 Feb 2022 10:36:51 -0800 (PST) MIME-Version: 1.0 References: <20220127140314.10264-1-philippe.reynes@softathome.com> <20220127140314.10264-2-philippe.reynes@softathome.com> <1d1e6038-e600-a72f-e4ed-39f553a26c8c@softathome.com> In-Reply-To: <1d1e6038-e600-a72f-e4ed-39f553a26c8c@softathome.com> From: Simon Glass Date: Sat, 26 Feb 2022 11:36:39 -0700 Message-ID: Subject: Re: [PATCH 2/2] tools: binman: main.py: add /tmp/sandbox sys.path To: Philippe REYNES Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Philippe, On Thu, 27 Jan 2022 at 08:15, Philippe REYNES wrote: > > Hi Simon, > > Le 27/01/2022 =C3=A0 16:06, Simon Glass a =C3=A9crit : > > Hi Philippe, > > > > On Thu, 27 Jan 2022 at 07:03, Philippe Reynes > > wrote: > >> Adds /tmp/sandbox to sys.path to look for libfdt, > >> otherwise ci is broken if a py_test uses binman. > >> > >> Signed-off-by: Philippe Reynes > >> --- > >> tools/binman/main.py | 1 + > >> 1 file changed, 1 insertion(+) > > Which test uses /tmp/sandbox to build U-Boot? We might need to use > > --toolpath for this, or set PYTHONPATH in the caller? > > > I have added a test that use binman in vboot (for global image signature, > a header added before the image). This path should be added for the CI, > otherwise tests "sandbox test.pyt " and "sandbox with clan test.py" fail. But the tests should run in the board directory provided to pytest. I will have to look at your test. > > > >> diff --git a/tools/binman/main.py b/tools/binman/main.py > >> index f62394043d..7d52482c0c 100755 > >> --- a/tools/binman/main.py > >> +++ b/tools/binman/main.py > >> @@ -42,6 +42,7 @@ sys.path.insert(2, 'scripts/dtc/pylibfdt') > >> sys.path.insert(2, os.path.join(srctree, 'scripts/dtc/pylibfdt')) > >> sys.path.insert(2, os.path.join(srctree, 'build-sandbox/scripts/dtc/= pylibfdt')) > >> sys.path.insert(2, os.path.join(srctree, 'build-sandbox_spl/scripts/= dtc/pylibfdt')) > >> +sys.path.insert(2, os.path.join(srctree, '/tmp/sandbox/scripts/dtc/py= libfdt')) > >> > >> # When running under python-coverage on Ubuntu 16.04, the dist-packa= ges > >> # directories are dropped from the python path. Add them in so that = we can find > >> -- > >> 2.17.1 > >> > > Regards, > > Simon > Regards, > Philippe > > > -- This message and any attachments herein are confidential, intended sol= ely for the addressees and are SoftAtHome=E2=80=99s ownership. Any unauthor= ized use or dissemination is prohibited. If you are not the intended addres= see of this message, please cancel it immediately and inform the sender. Is this supposed to be sent on the mailing list? Regards, Simon