From: Simon Glass <sjg@chromium.org>
To: Nandor Han <nandor.han@vaisala.com>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Tom Rini" <trini@konsulko.com>,
"Vesa Jääskeläinen" <vesa.jaaskelainen@vaisala.com>
Subject: Re: [PATCH v2 1/1] bootcount: add a new driver with syscon as backend
Date: Mon, 5 Jul 2021 09:55:55 -0600 [thread overview]
Message-ID: <CAPnjgZ3iiwRmqHvEFAWu05-aoH=h8g=H6XZCn3r2_X6=SsQF-Q@mail.gmail.com> (raw)
In-Reply-To: <3a1c85f25c7b071846759ad9a4ae21a1556f02c4.1623328711.git.nandor.han@vaisala.com>
On Thu, 10 Jun 2021 at 06:41, Nandor Han <nandor.han@vaisala.com> wrote:
>
> The driver will use a syscon regmap as backend and supports both
> 16 and 32 size value. The value will be stored in the CPU's endianness.
>
> Signed-off-by: Nandor Han <nandor.han@vaisala.com>
> ---
>
> Notes:
> Description
> -----------
> Add a new driver for bootcount feature that supports `syscon` device as
> backend.
>
> Testing
> -------
> UnitTests:
> 1. Verify that unit-tests run successfully: PASS
> ```
> ./test/py/test.py --bd sandbox --build -k ut_dm_bootcount -v
>
> test/py/tests/test_ut.py::test_ut[ut_dm_bootcount_rtc] PASSED [ 33%]
> test/py/tests/test_ut.py::test_ut[ut_dm_bootcount_syscon_four_bytes] PASSED [ 66%]
> test/py/tests/test_ut.py::test_ut[ut_dm_bootcount_syscon_two_bytes] PASSED [100%]
> ```
>
> Using hardware:
> Board: i.MX6sx based dev board
> U-Boot version: 2020.01
> 1. Use `bootcount` command to verity that value is updated
> correctly: PASS
>
>
> Changes since v1:
> - rebased
>
> arch/sandbox/dts/test.dts | 14 ++
> configs/sandbox_defconfig | 1 +
> doc/device-tree-bindings/bootcount-syscon.txt | 25 +++
> drivers/bootcount/Kconfig | 12 ++
> drivers/bootcount/Makefile | 1 +
> drivers/bootcount/bootcount_syscon.c | 159 ++++++++++++++++++
> test/dm/bootcount.c | 48 +++++-
> 7 files changed, 257 insertions(+), 3 deletions(-)
> create mode 100644 doc/device-tree-bindings/bootcount-syscon.txt
> create mode 100644 drivers/bootcount/bootcount_syscon.c
Reviewed-by: Simon Glass <sjg@chromium.org>
next prev parent reply other threads:[~2021-07-05 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 12:40 [PATCH v2 1/1] bootcount: add a new driver with syscon as backend Nandor Han
2021-07-05 15:55 ` Simon Glass [this message]
2021-08-23 4:33 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ3iiwRmqHvEFAWu05-aoH=h8g=H6XZCn3r2_X6=SsQF-Q@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=nandor.han@vaisala.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vesa.jaaskelainen@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.