From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Wed, 4 May 2016 14:30:22 -0600 Subject: [U-Boot] [PATCH V2] buildman: allow more incremental building In-Reply-To: <20160504202731.GC16759@bill-the-cat> References: <1460393324-2155-1-git-send-email-swarren@wwwdotorg.org> <572A4593.3070600@wwwdotorg.org> <20160504185828.GB16759@bill-the-cat> <572A48F1.70009@wwwdotorg.org> <20160504202731.GC16759@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4 May 2016 at 14:27, Tom Rini wrote: > On Wed, May 04, 2016 at 01:30:47PM -0600, Simon Glass wrote: >> Hi Tom, >> >> On 4 May 2016 at 13:09, Stephen Warren wrote: >> > On 05/04/2016 12:58 PM, Tom Rini wrote: >> >> >> >> On Wed, May 04, 2016 at 12:55:15PM -0600, Stephen Warren wrote: >> >>> >> >>> On 04/11/2016 10:48 AM, Stephen Warren wrote: >> >>>> >> >>>> From: Stephen Warren >> >>>> >> >>>> One use-case for buildman is to continually run it interactively after >> >>>> each small step in a large refactoring operation. This gives more >> >>>> immediate feedback than making a number of commits and then going back >> >>>> and >> >>>> testing them. For this to work well, buildman needs to be extremely >> >>>> fast. >> >>>> At present, a couple issues prevent it being as fast as it could be: >> >>>> >> >>>> 1) Each time buildman runs "make %_defconfig", it runs "make mrproper" >> >>>> first. This throws away all previous build results, requiring a >> >>>> from-scratch build. Optionally avoiding this would speed up the build, >> >>>> at >> >>>> the cost of potentially causing or missing some build issues. >> >>>> >> >>>> 2) A build tree is created per thread rather than per board. When a >> >>>> thread >> >>>> switches between building different boards, this often causes many files >> >>>> to be rebuilt due to changing config options. Using a separate build >> >>>> tree >> >>>> for each board would avoid this. This does put more strain on the >> >>>> system's >> >>>> disk cache, but it is worth it on my system at least. >> >>>> >> >>>> This commit adds two command-line options to implement the changes >> >>>> described above; -I ("--incremental") turns of "make mrproper" and -P >> >>>> ("--per-board-out-dir") creats a build directory per board rather than >> >>>> per >> >>>> thread. >> >>>> >> >>>> Tested: >> >>>> >> >>>> ./tools/buildman/buildman.py tegra >> >>>> ./tools/buildman/buildman.py -I -P tegra >> >>>> ./tools/buildman/buildman.py -b tegra_dev tegra >> >>>> ./tools/buildman/buildman.py -b tegra_dev -I -P tegra >> >>>> >> >>>> ... each once after deleting the buildman result/work directory, and >> >>>> once >> >>>> "incrementally" after a previous identical invocation. >> >>>> >> >>>> Signed-off-by: Stephen Warren >> >>>> Reviewed-by: Tom Rini >> >>>> Acked-by: Simon Glass # v1 >> >>>> Tested-by: Simon Glass # v1 >> >>> >> >>> >> >>> Tom, it's been over 3 weeks since I posted this, and Simon ack'd v2. >> >> >> >> >> >> Well, the release is next week. Simon didn't include it in a PR since >> >> v2 was posted so I assume he was figuring on waiting until next release >> >> for it. Does this really need to come in before the release or can it >> >> wait? >> >> No I was just expecting you to pick it up as it is in your queue :-) > > Welp, there you go then. pah, sorry, my fault. No worries, I just grabbed it and will apply when the merge window opens. - Simon