From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Fri, 31 Jul 2020 12:44:03 -0600 Subject: [PATCH v1 06/24] pci: pci-uclass: Add multi entry support for memory regions In-Reply-To: References: <20200724100856.1482324-1-sr@denx.de> <20200724100856.1482324-7-sr@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, On Thu, 30 Jul 2020 at 09:35, Stefan Roese wrote: > > Hi Simon, > > On 28.07.20 21:01, Simon Glass wrote: > > Hi Stefan, > > > > On Fri, 24 Jul 2020 at 04:09, Stefan Roese wrote: > >> > >> From: Suneel Garapati > >> > >> Enable PCI memory regions in ranges property to be of multiple entry. > >> This helps to add support for SoC's like OcteonTX/TX2 where every > >> peripheral is on PCI bus. > >> > >> Signed-off-by: Suneel Garapati > >> Cc: Simon Glass > >> Cc: Bin Meng > >> > >> Signed-off-by: Stefan Roese > >> --- > >> > >> Changes in v1: > >> - Change patch subject > >> - Enhance Kconfig help descrition > >> - Use if() instead of #if > >> > >> drivers/pci/Kconfig | 10 ++++++++++ > >> drivers/pci/pci-uclass.c | 9 ++++++--- > >> 2 files changed, 16 insertions(+), 3 deletions(-) > > > > This needs an update to a sandbox test to handle this behaviour. > > Okay. But how should I handle all these defconfig changes with regard > to the other patches in this series, introducing multiple new PCI > related Kconfig options. With 3 new Kconfig options, all permutations > would lead to 8 (2 ^ 3) different defconfig files. This does not > scale. > > I might be missing something here though - perhaps this is easier to > achieve. For sandbox, turn on all options and then add a new PCI bus that uses this functionality. If there are lots of combinations you could add 8 new buses, but I'm hoping that isn't necessary? Regards, Simon