All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] dm: x86: Allow TSC timer to be used before DM is ready
Date: Wed, 2 Aug 2017 12:08:45 -0600	[thread overview]
Message-ID: <CAPnjgZ3oYFGC2DQmjVV-7gLXbYu5vDWR+_038SpAr=F3t3mQxw@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmVxadeKLChYYNKH-qS1nHDKeOHWsi8B8uMGCJo9RbYOsA@mail.gmail.com>

Hi Bin,

On 22 July 2017 at 22:36, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Sun, Jul 16, 2017 at 7:41 AM, Simon Glass <sjg@chromium.org> wrote:
>> With bootstage we need access to the timer before driver model is set up.
>> To handle this, put the required state in global_data and provide a new
>> function to set up the device, separate from the driver's probe() method.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>>  arch/x86/include/asm/global_data.h |  1 +
>>  drivers/timer/tsc_timer.c          | 18 +++++++++++++-----
>>  2 files changed, 14 insertions(+), 5 deletions(-)
>>
>
> Please check my comments against [1/5] in this series. We should be
> able to do something with existing CONFIG_TIMER_EARLY. Updating TSC
> timer can only solve this specific timer issue.

Yes I agree. I did wonder about that at the time, but didn't investigate it.

I'll take a look at this next week when I have access to a link.

Regards,
Simon

  reply	other threads:[~2017-08-02 18:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 23:41 [U-Boot] [PATCH 0/5] x86: bootstage: Fix bootstage operation on link Simon Glass
2017-07-15 23:41 ` [U-Boot] [PATCH 1/5] board_f: Drop the timer after relocation Simon Glass
2017-07-23  4:36   ` Bin Meng
2017-08-02 18:07     ` Simon Glass
2017-07-15 23:41 ` [U-Boot] [PATCH 2/5] dm: x86: Allow TSC timer to be used before DM is ready Simon Glass
2017-07-23  4:36   ` Bin Meng
2017-08-02 18:08     ` Simon Glass [this message]
2017-07-15 23:41 ` [U-Boot] [PATCH 3/5] dm: x86: Update timer_get_boot_us to work " Simon Glass
2017-07-15 23:41 ` [U-Boot] [PATCH 4/5] bootstage: Drop unused options Simon Glass
2017-07-23  4:36   ` Bin Meng
2017-07-15 23:41 ` [U-Boot] [PATCH 5/5] bootstage: Provide a separate record count setting for SPL Simon Glass
2017-07-23  4:36   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3oYFGC2DQmjVV-7gLXbYu5vDWR+_038SpAr=F3t3mQxw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.