From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Fri, 23 Feb 2018 13:59:00 -0700 Subject: [U-Boot] [PATCH v1 1/4] mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat In-Reply-To: <1519295148-6817-2-git-send-email-jjhiblot@ti.com> References: <1519295148-6817-1-git-send-email-jjhiblot@ti.com> <1519295148-6817-2-git-send-email-jjhiblot@ti.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jean-Jacques, On 22 February 2018 at 03:25, Jean-Jacques Hiblot wrote: > The area for struct mmc can be allocated dynamically. It greatly reduces > the size of struct omap_hsmmc_plat. This is useful in cases where the board > level code declares one or two struct omap_hsmmc_plat because it doesn't > use the Driver Model. > > This saves around 740 bytes for the am335x_evm SPL. > > Signed-off-by: Jean-Jacques Hiblot > --- > > arch/arm/include/asm/omap_mmc.h | 2 +- > drivers/mmc/omap_hsmmc.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Simon Glass I would like to understand why this saves memory though. Presumably the pointer has to point to a real struct anyway, which uses memory. So how does this help? - Simon