From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sat, 13 Jun 2020 20:49:36 -0600 Subject: [PATCH 09/10] dtoc: update dtb_platdata to support cd-gpios In-Reply-To: References: <20200529181521.22073-1-walter.lozano@collabora.com> <20200529181521.22073-10-walter.lozano@collabora.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Walter, On Mon, 8 Jun 2020 at 10:01, Walter Lozano wrote: > > Hi Simon > > On 4/6/20 12:59, Simon Glass wrote: > > On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > >> Currently dtoc does not support the property cd-gpios used to declare > >> the gpios for card detect in mmc. > >> > >> This patch adds support to cd-gpios property. > >> > >> Signed-off-by: Walter Lozano > >> --- > >> tools/dtoc/dtb_platdata.py | 13 ++++++++----- > >> tools/dtoc/test_dtoc.py | 2 +- > >> 2 files changed, 9 insertions(+), 6 deletions(-) > > Reviewed-by: Simon Glass > > > > But I think you should mention GPIOs, rather than just cd-gpios, as it > > seems this will add support for any GPIO. > > Sorry, probably I am missing something, but in order to support GPIOs in > general we need to support a set of properties such as "cs-gpios", > "rb-gpios", "gpios" among others. > > Do you agree? OK yes I see. I was thinking of supporting any *-gpios but I think what you have here is better for now. Regards, Simon