From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1938DC433F5 for ; Sun, 30 Jan 2022 23:19:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 14B5B80D1C; Mon, 31 Jan 2022 00:19:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="H5wokKc6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7601D83046; Mon, 31 Jan 2022 00:19:42 +0100 (CET) Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A90C18091B for ; Mon, 31 Jan 2022 00:19:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe2c.google.com with SMTP id l14so9769757vsm.3 for ; Sun, 30 Jan 2022 15:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/llEst5oWd/P+Uxu1qtjp4As8vPKDI8xSzBpkCgYGq8=; b=H5wokKc6yrFh0BmAOVPdLJXkYrn0TRplUzvH88IQEObUD5HJEt1fruiRXBrl8nGaIE SZMxNajTC7wzBCjRyeISsAEfDhezYbDnIluEczLtoGxpf0M2QCXwa45zOgdVAGAhPKPO YAeXk1TwOcqIuKQhpyiP73jGUAx32tcKXpp1Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/llEst5oWd/P+Uxu1qtjp4As8vPKDI8xSzBpkCgYGq8=; b=HXHY04FuGM7CSgAbwQ/HS/SMbSoI6TlgezJRAoECD7PNspUjzAIhi17Uzctmf1JYG5 zxOPJOFIA3J4QKXwS9EjPqPgKXmzvpPMjEotz529enMyMpwHOFzJv3ZoNScuDva4XlP9 G/enoXxLJqieHUfwd3Gqg9hk3JpXhrSoR02VlE1iRFr8yY/kEYCh6Q4sZ928Ve18g5OO pHpvYxDKKDal1Rb8Q+bjzk0RiwhZ0WFwfP58NeTtE2K2O9RTsnoq9eMqjwKT379+64G2 onoLD0TWEcbrEthpXIM50Ewa8dRMNS1C81oScdOdUlbWmWmFUhcENJUGp3mIDVV+MaD8 eLgQ== X-Gm-Message-State: AOAM533+Sq8BoQrKVCXG/0GdFPeSfMrNPqHKKLhmuYo8ywVefHVXRv3k r6ILKUh/2u4YXazVR8F5WEklIMkCfm5LiJC0Icqqyw2H3q9PSg== X-Google-Smtp-Source: ABdhPJxnvtJS0nxzabhgKmdq/qcZG2KP/BZr4LTaP/eTwRApRstQSb/6v37y2xDTaqbRuzBdx/yQyoD5k+qBFlflG/o= X-Received: by 2002:a67:c296:: with SMTP id k22mr6797226vsj.19.1643584778228; Sun, 30 Jan 2022 15:19:38 -0800 (PST) MIME-Version: 1.0 References: <8d5198e1-7b6e-f08e-47eb-06d41ab0dff8@siemens.com> In-Reply-To: <8d5198e1-7b6e-f08e-47eb-06d41ab0dff8@siemens.com> From: Simon Glass Date: Sun, 30 Jan 2022 16:19:27 -0700 Message-ID: Subject: Re: [PATCH] binman: Skip node generation for images read from files To: Jan Kiszka Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Jan, On Fri, 28 Jan 2022 at 12:37, Jan Kiszka wrote: > > From: Jan Kiszka > > We can and should run the node generator only when creating a new image. > When we read it back, there is no need to generate nodes - they already > exits, and binman does not dive that deep into the image - and there is > no way to provide the required fdt-list. So store the mode in the image > object so that Entry_fit can simply skip generator nodes when reading > them from an fdtmap. > > This unbreaks all read-backs of images that contain generator nodes in > their fdtmap. To confirm this, add a corresponding test case. > > Signed-off-by: Jan Kiszka > --- > tools/binman/etype/fit.py | 2 +- > tools/binman/ftest.py | 18 ++++++++++++++++++ > tools/binman/image.py | 9 +++++++-- > tools/binman/test/219_fit_gennode.dts | 24 ++++++++++++++++++++++++ > 4 files changed, 50 insertions(+), 3 deletions(-) > create mode 100644 tools/binman/test/219_fit_gennode.dts (version 3 patch) Reviewed-by: Simon Glass Tested-by: Simon Glass This has a lot of merge conflicts but they are my fault, so I am going to tidy them up. PLMK if something looks wrong. Regards, Simon