From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Wed, 27 Jan 2021 08:15:41 -0700
Subject: [PATCH v2 27/28] fs/squashfs: sqfs_read: fragmented files are not
 supported
In-Reply-To: <03f095f4-e803-e5e1-1406-c6ba50f42108@posteo.net>
References: <20201103111126.23600-1-richard.genoud@posteo.net>
 <20201103111126.23600-28-richard.genoud@posteo.net>
 <20201120013538.GE32272@bill-the-cat>
 <03f095f4-e803-e5e1-1406-c6ba50f42108@posteo.net>
Message-ID: <CAPnjgZ3s72OzqNd-OqgxyCMQbm+3eqbZB90CEy-h3DoPLic9tw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Joao,

On Wed, 25 Nov 2020 at 01:58, Richard Genoud <richard.genoud@posteo.net> wrote:
>
> Hi,
>
> Le 20/11/2020 ? 02:35, Tom Rini a ?crit :
> > On Tue, Nov 03, 2020 at 12:11:25PM +0100, Richard Genoud wrote:
> >
> >> The code for reading a fragmented file is not functionnal.
> >> It's better to signal this to the user.
> >>
> >> Signed-off-by: Richard Genoud <richard.genoud@posteo.net>
> >
> > This change causes the test.py squashfs tests to fail.  I am unsure if
> > the problem is with the tests or this exposing further problems in the
> > code.
> Actually, reading a fragmented file doesn't work.
> The test only check if the file is read, but not it's content.
>
> With this following patch, we'll see that the file content is not the same :
>
>
>  From 68f87301c059aaae8e90e42fbec9b560aee0c6eb Mon Sep 17 00:00:00 2001
> From: Richard Genoud <richard.genoud@posteo.net>
> Date: Tue, 24 Nov 2020 17:45:07 +0100
> Subject: [PATCH] test/py: SquashFS: Check if loaded file is corrupted
>
> After loading the file in memory, its content should be checked for
> errors.
>
> Signed-off-by: Richard Genoud <richard.genoud@posteo.net>
> ---
>   test/py/tests/test_fs/test_squashfs/sqfs_common.py    | 5 ++++-
>   test/py/tests/test_fs/test_squashfs/test_sqfs_load.py | 6 +++++-
>   2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/test/py/tests/test_fs/test_squashfs/sqfs_common.py b/test/py/tests/test_fs/test_squashfs/sqfs_common.py
> index c96f92c1d8f..a7673c73762 100644
> --- a/test/py/tests/test_fs/test_squashfs/sqfs_common.py
> +++ b/test/py/tests/test_fs/test_squashfs/sqfs_common.py

This test works the first time I run it but fails the second time,
since the directory already exists. This makes it necessary to disable
the test for development.

It also uses the wrong quoting style - we have settled on a single
quote by default in U-Boot.

Finally, the tests and some functions need comments about what they do
and what the arguments are.

Please can you take a look?

Thanks,
Simon