From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B56C433F5 for ; Fri, 22 Oct 2021 03:06:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5CF261503 for ; Fri, 22 Oct 2021 03:06:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A5CF261503 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2E74883508; Fri, 22 Oct 2021 05:06:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mvMXv+LH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7A219834F4; Fri, 22 Oct 2021 05:06:23 +0200 (CEST) Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8749F834F1 for ; Fri, 22 Oct 2021 05:06:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x934.google.com with SMTP id f3so5088619uap.6 for ; Thu, 21 Oct 2021 20:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=54jM5m/UnGQ0Q5lPoisjSyG5MJN6hgeZRiFNKW8W228=; b=mvMXv+LHMmUHUMGyyPMuGv8pHGEjBlsUW7VJeouoKTXXCx8sEhnH2GJrJ/rqgsl1/o MZDwTV3SOCxCL2YHg9NxeQMumlni4oSzTotvrU5cOYZcdEhafkj4PRlooFv0leei5J0v O8J+Lnvj3aSYHsZ/lYQRORNUtlXMQLdC6IzxI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=54jM5m/UnGQ0Q5lPoisjSyG5MJN6hgeZRiFNKW8W228=; b=o3N3SHIDuVksrOQGOMoWlrKV+fcwM/ghT23C5dXprrJFemoBWG+IxxwOQXvBUU6rup ktdL+3Ica5z9M8J/dQiEUs94ODk+XA05EZH3VmzX9icygUvfqShkGY96fghox0MRFIc1 FzIHJ7c6UbSkEsg/ETmkZPkf7dDRp5NDh47NOlsR2Ep9vOSMdavS5YR2uCIIQAToiYX3 1tMw0wTPc1HVokDOyS1Eusy8HdZ+aUhUDpLROlVYQGFFC2rOjMBKSS02qM7e3HZEHSKp f3DudUBl7GrWV4PEOScmzyetP2YMEpa2sm/BdmUuMxcEUscyubudZDW70ir+pIphE1AK IJqg== X-Gm-Message-State: AOAM530tWc2GUoCko05sGbjVdRHLHe/pl1wA5aMJ7weT6FZI5pKtU/IM zbHPDo+jFqOfwabg6A7LvzRXxG32Wk/Vqgb5f3tVDQ== X-Google-Smtp-Source: ABdhPJwNngU8k61NGx6nrQ1OJeqEEuAQhdrjwS7ZTMQd0VzM8+93hJZf8/veL7kj6HDMA50wJuUyQkn/e4E8/84GpD0= X-Received: by 2002:ab0:4952:: with SMTP id a18mr11449548uad.35.1634871977191; Thu, 21 Oct 2021 20:06:17 -0700 (PDT) MIME-Version: 1.0 References: <20211020034325.1497038-1-sjg@chromium.org> <20211020034325.1497038-2-sjg@chromium.org> <20211021121308.GW7964@bill-the-cat> <20211021161554.GD3577824@bill-the-cat> <29921036-f02b-dd8f-4d67-520f02eb2a35@denx.de> In-Reply-To: <29921036-f02b-dd8f-4d67-520f02eb2a35@denx.de> From: Simon Glass Date: Thu, 21 Oct 2021 21:06:05 -0600 Message-ID: Subject: Re: [PATCH 2/3] buildman: Detect Kconfig loops To: Stefano Babic Cc: Tom Rini , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Stefano, On Thu, 21 Oct 2021 at 10:35, Stefano Babic wrote: > > Hi Simon, > > On 21.10.21 18:15, Tom Rini wrote: > > On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: > >> Hi Tom, > >> > >> On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > >>> > >>> On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > >>> > >>>> Hex and int Kconfig options are supposed to have defaults. This is so we > >>>> can configure U-Boot without having to enter particular values for the > >>>> items that don't have specific values in the board's defconfig file. > >>> > >>> That's not true. All symbols that we can make reasonable defaults for > >>> get them. It's just that for boolean n is a reasonable default. > >>> int/hex often just need to be entered, period. > >>> > >>> Everything else is fine however, thanks for digging in to this. > >> > >> I got that from there and it made sense as to why we have this problem: > >> > >> https://docs.zephyrproject.org/2.4.0/guides/kconfig/tips.html#redundant-defaults > > > > Yeah, we're just in the bad spot because of things not being fully > > migrated. > > > >> But I think you are right if we should update the commit message here > >> to avoid confusion. Shall I send v2? > > > > Yes please. > > As delta... Oh I can't do that as it was the commit message that needed to change. > I applied 1-2 to u-boot-imx (else I was stuck), and they are already > merged as part of my PR. Your patches are already on -master. It's fine, just an error that I doubt people will not notice / get confused by. Regards, Simon