From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 3/3] efi_loader: setting boot device
Date: Tue, 19 Jan 2021 17:15:56 -0700 [thread overview]
Message-ID: <CAPnjgZ3u3wS_zazFrJ549baa3s=+hT8OKis-KPeZSOUWFfJVzQ@mail.gmail.com> (raw)
In-Reply-To: <fb4525ec-de44-5330-ff99-4eef5511927e@gmx.de>
Hi Heinrich,
On Tue, 19 Jan 2021 at 11:43, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 1/19/21 7:06 PM, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Tue, 12 Jan 2021 at 12:58, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >>
> >> Up to now the bootefi command used the last file loaded to determine the
> >> boot partition. This has led to errors when the fdt had been loaded from
> >> another partition after the EFI binary.
> >>
> >> Before setting the boot device from a loaded file check if it is a PE-COFF
> >> image or a FIT image.
> >>
> >> For a PE-COFF image remember address and size, boot device and path.
> >>
> >> For a FIT image remember boot device and path.
> >>
> >> If the PE-COFF image is overwritten by loading another file, forget it.
> >>
> >> Do not allow to start an image via bootefi which is not the last loaded
> >> PE-COFF image.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >> ---
> >> cmd/bootefi.c | 136 ++++++++++++++++++++++++++-----------------
> >> doc/uefi/uefi.rst | 11 ++--
> >> fs/fs.c | 3 +-
> >> include/efi_loader.h | 6 +-
> >> net/tftp.c | 9 ++-
> >> 5 files changed, 98 insertions(+), 67 deletions(-)
> >>
> >
> > Does this need an update to the tests?
>
> Our current tests still run successfully.
>
> The observed problematic behavior is not covered by our tests. To run
> GRUB or helloworld.efi we just load one file and execute it.
>
> So it would make sense to extend the coverage of our tests with a future
> patch.
Yes indeed.
Regards,
Simon
next prev parent reply other threads:[~2021-01-20 0:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 19:58 [PATCH 0/3] efi_loader: setting boot device Heinrich Schuchardt
2021-01-12 19:58 ` [PATCH 1/3] efi_loader: print boot device and file path in helloworld Heinrich Schuchardt
2021-01-14 15:42 ` Simon Glass
2021-01-15 1:56 ` AKASHI Takahiro
2021-01-15 3:12 ` Heinrich Schuchardt
2021-01-15 4:29 ` AKASHI Takahiro
2021-01-15 12:02 ` Heinrich Schuchardt
2021-01-18 1:38 ` AKASHI Takahiro
2021-01-12 19:58 ` [PATCH 2/3] efi_loader: carve out efi_check_pe() Heinrich Schuchardt
2021-01-14 15:42 ` Simon Glass
2021-01-12 19:58 ` [PATCH 3/3] efi_loader: setting boot device Heinrich Schuchardt
2021-01-19 18:06 ` Simon Glass
2021-01-19 18:43 ` Heinrich Schuchardt
2021-01-20 0:15 ` Simon Glass [this message]
2022-04-03 21:08 ` Kyle Evans
2022-04-04 5:09 ` Heinrich Schuchardt
2022-04-04 5:40 ` Kyle Evans
2022-04-04 5:58 ` Heinrich Schuchardt
2022-04-04 14:51 ` Kyle Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ3u3wS_zazFrJ549baa3s=+hT8OKis-KPeZSOUWFfJVzQ@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.