From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] cpu: Add cpu_print_info function
Date: Thu, 12 Apr 2018 10:37:38 -0600 [thread overview]
Message-ID: <CAPnjgZ3u8q8n6kk5grzownqLAuFo7YUFQMm8Gq=oUF5niqam8A@mail.gmail.com> (raw)
In-Reply-To: <CAN1kZopFviGwt+xYJO-5QnOrnDpqUQNCQnP4-uYYgQfsTKXugw@mail.gmail.com>
Hi Mario,
On 11 April 2018 at 00:39, Mario Six <mario.six@gdsys.cc> wrote:
> Hi Simon,
>
> On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <sjg@chromium.org> wrote:
>> Hi,
>>
>> On 28 March 2018 at 20:38, Mario Six <mario.six@gdsys.cc> wrote:
>>> Add a cpu_print_info function to the CPU uclass to emulate the behavior
>>> of some current non-DM drivers (e.g. MPC83xx) to print CPU information
>>> during startup.
>>>
>>> Signed-off-by: Mario Six <mario.six@gdsys.cc>
>>> ---
>>> drivers/cpu/cpu-uclass.c | 10 ++++++++++
>>> include/cpu.h | 15 +++++++++++++++
>>> 2 files changed, 25 insertions(+)
>>>
>>
>> I really don't want drivers printing stuff. Can you use the existing
>> get_info() method?
>>
>
> I could, but I'm just emulating the behavior of the legacy code here, which
> prints some information when the CPU is initialized. I think that's pretty
> useful, and I can do that in our board file, but that would mean implementing
> the same routine in every MPC83xx board to get the legacy behavior back.
Yes, but I don't want the legacy code creeping into the eclass. Can
you convert the board to use the CPU eclass instead?
Regards,
Simon
next prev parent reply other threads:[~2018-04-12 16:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 12:38 [U-Boot] [PATCH 1/8] core: Add uclass_{first,next}_device_compat Mario Six
2018-03-28 12:38 ` [U-Boot] [PATCH 2/8] test: Add tests for uclass_{first, next}_device_compat Mario Six
2018-03-28 12:38 ` [U-Boot] [PATCH 3/8] ram: Add driver for MPC83xx Mario Six
2018-03-28 12:38 ` [U-Boot] [PATCH 4/8] clk: Add MPC83xx clock driver Mario Six
2018-03-28 12:38 ` [U-Boot] [PATCH 5/8] timer: Add MPC83xx timer driver Mario Six
2018-03-28 12:38 ` [U-Boot] [PATCH 6/8] cpu: Add cpu_print_info function Mario Six
2018-03-30 8:41 ` Simon Glass
2018-04-11 6:39 ` Mario Six
2018-04-12 16:37 ` Simon Glass [this message]
2018-04-18 8:35 ` Mario Six
2018-04-18 15:45 ` Simon Glass
2018-04-19 7:50 ` Mario Six
2018-04-24 21:53 ` Simon Glass
2018-04-26 6:07 ` Mario Six
2018-04-26 14:40 ` Simon Glass
2018-04-27 12:16 ` Mario Six
2018-03-28 12:38 ` [U-Boot] [PATCH 7/8] cpu: Add MPC83xx CPU driver Mario Six
2018-03-28 12:38 ` [U-Boot] [PATCH 8/8] misc: Add MPC83xx serdes driver Mario Six
2018-03-30 8:41 ` [U-Boot] [PATCH 1/8] core: Add uclass_{first, next}_device_compat Simon Glass
2018-04-11 7:15 ` Mario Six
2018-04-12 16:31 ` Simon Glass
2018-04-18 9:02 ` Mario Six
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ3u8q8n6kk5grzownqLAuFo7YUFQMm8Gq=oUF5niqam8A@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.