From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F3D5C433EF for ; Wed, 9 Mar 2022 03:10:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE6138309E; Wed, 9 Mar 2022 04:10:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Ycu+8G8/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2859482DB7; Wed, 9 Mar 2022 04:10:19 +0100 (CET) Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2B6A68309E for ; Wed, 9 Mar 2022 04:10:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe35.google.com with SMTP id z85so908246vsz.5 for ; Tue, 08 Mar 2022 19:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6nYQeecg49+UxMk6VuQIUQIY5qgp+oHrsNXGN9RPXYo=; b=Ycu+8G8/MBk46DfoRPeTzGMBIiBXN1V5u/fDa9izp9HP2YHRjfRCAK5UoOKKLCQwJw aJOw1rHS3RvfDgC8Hjib87iIwl92BPxh6jZTUs88jbWT/wnnwWpCJVCWqC8oy0JdObXN bVrpnoM1rDyNfCGkektmFAyOIPvYL48YcBsvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6nYQeecg49+UxMk6VuQIUQIY5qgp+oHrsNXGN9RPXYo=; b=pMFu6BAxdBR4xa51Gb7Yq+YbH1yyuFXRw7t7yc2LDO10tL3AkIOZqORPziouqS+6H8 YpT4xpGkR304M5eT1gPRTv/paQOUCHq0ua+rmAihdtZwkOMXcfMowdIGD3nxBgN3Qz6P UBqvkCcBFfqsm+Z3Xordg0GyceuMjEj6VYvcQYRVfXIR/i9uH7kBMxPkL5G+Vj9hTOUe 4ectgQpQABHWDxnPs05JP2sIFVTjOQC60usW+8N2Kf5iVSIL34HEqsuvvVs15vBdCSEn E+7cz06FL4wvtBIjp6iIbb7vkQXO0Ezxv6r5c4J2KoQHGshfh6aaILiVux/wsNw4jq1Z nlKg== X-Gm-Message-State: AOAM530sm1ecFlcMJyqeZgPkHw0NLyJ3LQNR4Dfloa+uo7M6QrBPQ1oO AyxXffNADKC9JWHhn6jU4BFz5rbHMSQ/LcYn9hmdkA== X-Google-Smtp-Source: ABdhPJyk+w2ntzjBu7aaIWzc5+2TQp10yg/cdOHZd1SYpczQSQOZ6HFLl6yhgrQMfwuI3/mtNBfTksBdH5aMbMsrAaY= X-Received: by 2002:a67:fd09:0:b0:322:85fa:6c05 with SMTP id f9-20020a67fd09000000b0032285fa6c05mr593688vsr.71.1646795412459; Tue, 08 Mar 2022 19:10:12 -0800 (PST) MIME-Version: 1.0 References: <20220308113657.221101-1-takahiro.akashi@linaro.org> <82d88a69-159a-257d-2fcb-b6226bff6fe4@gmx.de> <20220309021006.GA136899@laputa> <20220309024839.GC136899@laputa> In-Reply-To: <20220309024839.GC136899@laputa> From: Simon Glass Date: Tue, 8 Mar 2022 20:10:01 -0700 Message-ID: Subject: Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Masami Hiramatsu , U-Boot Mailing List , Lukasz Majewski , Peng Fan , Bin Meng , Jaehoon Chung , Stefan Roese , Ilias Apalodimas Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Takahiro, On Tue, 8 Mar 2022 at 19:48, AKASHI Takahiro wrote: > > Hi Simon, > > On Tue, Mar 08, 2022 at 07:34:15PM -0700, Simon Glass wrote: > > Hi Takahiro, > > > > On Tue, 8 Mar 2022 at 19:10, AKASHI Takahiro wrote: > > > > > > Heinrich, Simon, > > > > > > On Tue, Mar 08, 2022 at 05:49:13PM +0100, Heinrich Schuchardt wrote: > > > > On 3/8/22 12:36, AKASHI Takahiro wrote: > > > > > With this patch set[1] applied, UEFI subsystem maintains a list of its > > > > > disk objects dynamically at runtime based on block device's probing. > > > > > (See "issues" below.) > > > > > > > > > > [1]https://github.com/t-akashi/u-boot/tree/efi/dm_disk > > > > > > > > This series together with Simon's series breaks multiple boards due to > > > > size constraints: > > > > > > > > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/11197 > > > > > > > > Please, investigate how to work around this issue. > > > > > > I have already mentioned this size issue in my cover-letter > > > in order to let reviewers aware of it and discuss a possible solution: > > > > > > ===8<=== > > > Issues: > > > ======= > > > * The image size of U-Boot may increase. CI build test complains, > > > for instance, > > > rcar3_salvator-x: > > > "u-boot.img exceeds file size limit: ... excess: 0x79c bytes" > > > phycore-rk3288: > > > "SPL image is too large (size 0x8800 than 0x8000)" > > > > > > See [2]. > > > > > > [2] https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3770&view=results > > > ===>8=== > > > > > > I have dug into rcar3_salvator-x case; I removed *all* the commits > > > in this series and yet enabled CONFIG_EVENT, CONFIG_EVENT_DYNAMIC > > > and CONFIG_DM_EVENT, which are all required for enabling my patch, > > > with Simon's patch applied on top of v2022.04-rc3. > > > > > > Then I still see this size problem: > > > ===8<=== > > > ... > > > MKIMAGE u-boot.img > > > u-boot.img exceeds file size limit: > > > limit: 0x100000 bytes > > > actual: 0x100036 bytes > > > excess: 0x36 bytes > > > ===>8=== > > > > > > So I have no way to deal with it. > > > > > > FYI, the combination of EVENT, EVENT_DYNAMIC and DM_EVENT will > > > increase the binary size by up to 0x1b2 for rcar3_salvator-x and > > > it seems the binary has almost already reached its maximum size > > > even now. > > > > So you do need EVENT_DYNAMIC? > > Unfortunately, yes. > When I rebased my patch set to your v2, I tried to use *static* > bindings, but some of ut tests, including dm_test_blk_base and > dm_test_blk_usb, failed. OK. Well maybe there is a filesystem in there that is not needed? 1MB is a huge size! Can we disable EFI_LOADER on that board? > > This can happen because, with static bindings, efi's callback function > (efi_disk_probe) is unconditionally called even when UEFI subsystem has > not been initialized yet. Yes, I have seen things like that too. > > -Takahiro Akashi > > > Does it make sense to make enabling the partition support an option, > > instead of mandatory? What about this one? ^^ Regards, Simon