From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Tue, 7 Mar 2017 10:01:02 -0700 Subject: [U-Boot] rockchip breakage with "spl: Remove overwrite of relocated malloc limit" In-Reply-To: <58BE599A.3040409@rock-chips.com> References: <5416401.pcIAmeSpSx@diego> <58BE599A.3040409@rock-chips.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi, On 6 March 2017 at 23:56, Kever Yang wrote: > Hi Heiko, > > That patch break all the Rockchip SoCs SPL which using spl_init(). > > Eddie send one patch for rk3288 by add a spl_early_init(), which is > under review, I also look forward for better solution. Is this a problem for the upcoming release? I have not seen the breakage on firefly (although I found a few other problems) so did not think it needed to be resolved right away. Regards, Simon > > Thanks, > - Kever > > On 03/07/2017 08:42 AM, Heiko St=C3=BCbner wrote: >> >> Hi, >> >> I just realized patch b3d2861eb20a ("spl: Remove overwrite of relocated >> malloc >> limit") introduces breakage in my rk3188 uboot code (and should most >> likely >> also affect the very similar other rockchip spl boards). >> >> The boards call spl_init in their board_init_f functions because they ne= ed >> the >> spl infrastructure to find and bringup the devicetree stuff and things >> like >> pinctrl and ram. >> >> With the recent change mentioned above, spl_init fails with >> spl_init() failed: -12 >> because >> dm_init_and_scan() returned error -12 >> because >> dm_init() failed: -12 >> ... >> because >> Missing uclass for driver root_driver >> because >> uclass_add calls calloc, which fails with the -ENOMEM (-12) >> >> I still lack uboot experience to see the correct way forward. Reverting >> that >> patch of course makes my board start uboot again [and most likely the >> other >> Rockchip SPLs as well], but there is possibly some better solution >> [Or there is simply something very wrong with my rk3188 stuff :-) ]. >> >> >> Heiko >> _______________________________________________ >> U-Boot mailing list >> U-Boot at lists.denx.de >> https://lists.denx.de/listinfo/u-boot > > >