All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: "Jérôme Carretero" <cJ-uboot@zougloub.eu>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] boot: image: fixup zstd decompression buffer initialization typo
Date: Wed, 16 Mar 2022 13:23:45 -0600	[thread overview]
Message-ID: <CAPnjgZ3v4jWcqgjn7T0d95G8RG25=Jgw9d7okqDAU65yh8M5iQ@mail.gmail.com> (raw)
In-Reply-To: <20220316181555.3431754-1-cJ-uboot@zougloub.eu>

Hi Jérôme,

On Wed, 16 Mar 2022 at 12:16, Jérôme Carretero <cJ-uboot@zougloub.eu> wrote:
>

Thanks for the fix! Please add a commit message.

> Fixes: 458b30af66cd41ca8e6f8a52ea4c09cb50d3413d
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  boot/image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Fixes: 458b30af66c image: Update image_decomp() to avoid ifdefs

>
> diff --git a/boot/image.c b/boot/image.c
> index 07fa2d3160..121df0c838 100644
> --- a/boot/image.c
> +++ b/boot/image.c
> @@ -500,7 +500,7 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
>                         struct abuf in, out;
>
>                         abuf_init_set(&in, image_buf, image_len);
> -                       abuf_init_set(&in, load_buf, unc_len);
> +                       abuf_init_set(&out, load_buf, unc_len);
>                         ret = zstd_decompress(&in, &out);
>                         if (ret >= 0) {
>                                 image_len = ret;
> --
> 2.35.1
>

Regards,
Simon

      reply	other threads:[~2022-03-16 19:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 18:15 [PATCH] boot: image: fixup zstd decompression buffer initialization typo Jérôme Carretero
2022-03-16 19:23 ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3v4jWcqgjn7T0d95G8RG25=Jgw9d7okqDAU65yh8M5iQ@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=cJ-uboot@zougloub.eu \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.