From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94637C433EF for ; Sat, 25 Sep 2021 13:41:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE06261250 for ; Sat, 25 Sep 2021 13:41:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE06261250 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6FEA28351C; Sat, 25 Sep 2021 15:41:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="lbdqFD1d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5E237832AD; Sat, 25 Sep 2021 15:41:19 +0200 (CEST) Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AD174832AD for ; Sat, 25 Sep 2021 15:41:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe32.google.com with SMTP id y141so13066472vsy.5 for ; Sat, 25 Sep 2021 06:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m5E3uMM9KRbR/BYO8LG338Y5Z0MNqaBb06Xds14Es5E=; b=lbdqFD1dAJOJbHsawgcBuulF8ZMqdZNf9xtuuqgSf8lX9KSuT1ZKFd+XMW8Y+UFsV4 uZI+oTMvmBMkucw9mDxRWsad0bwj6uEOqWW7t7kd7v0miuwELFM3nkYCLnZAwgRHxKZ4 L3eAh3cdSUHjc1RvP3LP8yiXTIizpGC1nKiMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m5E3uMM9KRbR/BYO8LG338Y5Z0MNqaBb06Xds14Es5E=; b=P3lmXeP1CL+LNrvo7eLAmFgDql9Zbn9p+wzN46O+2UgYTM7hYfiGibhO6uiKCO+kcX GvNSGh/pW2D1wEPq/lfiq3eTayePGkN969xE+4YS2Y7p97GlMQboQ3c7i0gVMDat3f74 jau1ugiNOAzgNJcYVTixH8tjlBgrIbYIh8sIq+1KILTI5sTPGLzqk1pljM3O/kGTuJEW cr94KS5IuBDp858eqQ+V1a5H+DkqcuuzdMxvjFCAiclXhLK7vbRFakB4naI9DDjQ2MWY jhRJHVlEYZ+bNa27AxQKZkdjwy6/s7H+PPgZXg20oKyok5AeVA6X5ngXkSsnx8tecoZT 5yqA== X-Gm-Message-State: AOAM531w8PBoQvkz36dwN72ogU79nFLx7zL1y2Eew20qKf+ys4Mg72C4 OaBdlQUm25mUzsvOtefSiHO94N5YbBJiWEEEs8tEPg== X-Google-Smtp-Source: ABdhPJwg0WQPnzpeP40DFcwOHLqrFBf4sCYOCtPDxffqO3K9FvRM2bLX9GZik7jmLtjcrOzVFJWjnjjVait2qD8tcus= X-Received: by 2002:a05:6102:3a59:: with SMTP id c25mr13476457vsu.15.1632577271530; Sat, 25 Sep 2021 06:41:11 -0700 (PDT) MIME-Version: 1.0 References: <20210916130117.20894-1-kettenis@openbsd.org> <20210916130117.20894-4-kettenis@openbsd.org> In-Reply-To: <20210916130117.20894-4-kettenis@openbsd.org> From: Simon Glass Date: Sat, 25 Sep 2021 07:41:00 -0600 Message-ID: Subject: Re: [PATCH 3/3] video: simplefb: Add 30bpp support To: Mark Kettenis Cc: U-Boot Mailing List , Anatolij Gustschin , Heinrich Schuchardt , Alexander Graf Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 16 Sept 2021 at 07:02, Mark Kettenis wrote: > > Recognize the canonical format strings for framebuffers in > 30bpp mode. > > Signed-off-by: Mark Kettenis > --- > drivers/video/simplefb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c > index fd58426cf5..7e1cc4560f 100644 > --- a/drivers/video/simplefb.c > +++ b/drivers/video/simplefb.c > @@ -52,6 +52,9 @@ static int simple_video_probe(struct udevice *dev) > uc_priv->bpix = VIDEO_BPP16; > } else if (strcmp(format, "a8b8g8r8") == 0) { > uc_priv->bpix = VIDEO_BPP32; > + } else if (strcmp(format, "a2r10g10b10") == 0 || > + strcmp(format, "x2r10g10b10") == 0) { > + uc_priv->bpix = VIDEO_BPP30; > } else { > printf("%s: invalid format: %s\n", __func__, format); > return -EINVAL; > -- > 2.33.0 > Reviewed-by: Simon Glass Tested on: Macbook Air M1 Tested-by: Simon Glass