All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v2 6/7] x86: Add an indication of 32/64-bit to bdinfo
Date: Sun, 26 Apr 2020 14:32:01 -0600	[thread overview]
Message-ID: <CAPnjgZ3wHtS4D3mHr-+14uoe0xODvK+mCg-P_8k5r9Z8NuKPbw@mail.gmail.com> (raw)
In-Reply-To: <77ab3c57-a320-b775-59f5-bd852bd7b782@gmx.de>

Hi Heinrich,

On Sun, 26 Apr 2020 at 14:21, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 4/26/20 9:38 PM, Simon Glass wrote:
> > It is useful to know what mode U-Boot is running in. Add a message at the
> > end of the 'bdinfo' output.
>
> X86 is not the only architecture that can run both in 32bit and 64bit
> mode. The same is true for ARM and SANDBOX. Shouldn't we provide the
> information for these architecture too?
>
> The Raspberry Pi 3 is an example of an ARM board where building either
> 32bit or 64bit U-Boot is used depending on the bitness of the OS.

Yes I think that would be good. But do we have a generic way to tell?
sizeof(int) ?

Regards,
Simon


>
> Best regards
>
> Heinrich
>
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > Changes in v2:
> > - Add a new patch to indicate 32/64-bit in bdinfo
> >
> >  cmd/bdinfo.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
> > index d6a7175b37..a3129c9fe1 100644
> > --- a/cmd/bdinfo.c
> > +++ b/cmd/bdinfo.c
> > @@ -388,6 +388,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> >       print_mhz("ethspeed",       bd->bi_ethspeed);
> >  #endif
> >       print_baudrate();
> > +     printf("Build: %d-bit\n", CONFIG_IS_ENABLED(X86_64) ? 64 : 32);
> >
> >       return 0;
> >  }
> >
>

  reply	other threads:[~2020-04-26 20:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 19:38 [PATCH v2 0/7] x86: efi: Add a 64-bit coreboot payload Simon Glass
2020-04-26 19:38 ` [PATCH v2 1/7] x86: Allow building an SPL image for coreboot Simon Glass
2020-04-26 19:38 ` [PATCH v2 2/7] x86: Move work-around out of cpu_jump_to_64bit_uboot() Simon Glass
2020-04-26 19:38 ` [PATCH v2 3/7] x86: Update SPL for coreboot Simon Glass
2020-04-26 19:38 ` [PATCH v2 4/7] x86: cbfs: Drop unwanted declaration Simon Glass
2020-04-26 19:38 ` [PATCH v2 5/7] x86: coreboot: Allow building an SPL image Simon Glass
2020-04-26 19:38 ` [PATCH v2 6/7] x86: Add an indication of 32/64-bit to bdinfo Simon Glass
2020-04-26 20:21   ` Heinrich Schuchardt
2020-04-26 20:32     ` Simon Glass [this message]
2020-04-26 21:14       ` Heinrich Schuchardt
2020-04-26 21:23         ` Mark Kettenis
2020-04-26 19:38 ` [PATCH v2 7/7] x86: Add a 64-bit coreboot build Simon Glass
2020-04-30 13:56 ` [PATCH v2 0/7] x86: efi: Add a 64-bit coreboot payload Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3wHtS4D3mHr-+14uoe0xODvK+mCg-P_8k5r9Z8NuKPbw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.