From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 4 Feb 2021 20:17:21 -0700 Subject: [PATCH v3 12/12] smbios: Allow a few values to come from sysinfo In-Reply-To: References: <20210124174331.3462226-1-sjg@chromium.org> <20210124174331.3462226-5-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bin, On Mon, 1 Feb 2021 at 00:25, Bin Meng wrote: > > Hi Simon, > > On Mon, Jan 25, 2021 at 1:51 AM Simon Glass wrote: > > > > While static configuration is useful it cannot cover every case. Sometimes > > board revisions are encoded in resistor straps and must be read at > > runtime. > > > > The easiest way to provide this information is via sysinfo, since the > > board can then provide a driver to read whatever is needed. > > > > Add some standard sysinfo options for this, and use them to obtain the > > required information. > > > > Signed-off-by: Simon Glass > > > > I guess you used patman to automatically collect the Reviewed-by tag? > > Is this blank line inserted by patman? If yes, we should fix patman to > avoid this. Yes I use patman to collect review tags and also to show comments. I find it much more convenient than using the web interface. I believe that bug is fixed now, but let's see if it happens again. Regards, Simon