From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Thu, 14 Feb 2019 17:23:06 +0100
Subject: [U-Boot] [U-Boot, v4,
	1/1] avb: add support for named persistent values
In-Reply-To: <CAModR+WYH9TqbFDUkBTRcxoyd9yWB98g51+2jjwhB+j5HhudmA@mail.gmail.com>
References: <1548599645-9252-1-git-send-email-igor.opaniuk@linaro.org>
 <20190209125037.GF16814@bill-the-cat>
 <CAModR+VEYLo3wg22k7quG8-He+c0FSHuWWD+dskHyHXbuDEJxQ@mail.gmail.com>
 <20190211153028.GF16814@bill-the-cat>
 <CAModR+UMWXSx9fu5WDHHDoYdR5KwYQjFdHSb_3xT0Su_U_J1tw@mail.gmail.com>
 <CAPnjgZ0=Ot5UPQ2iBP5=JTxqUG9SuyraL5Urwis2wTewAcTLWg@mail.gmail.com>
 <CAModR+WYH9TqbFDUkBTRcxoyd9yWB98g51+2jjwhB+j5HhudmA@mail.gmail.com>
Message-ID: <CAPnjgZ3xmg5eWW+tT7=aDnv=U7vHLQ8NZZ03A2vJix8x4i6p=A@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

HI Igor,

On Wed, 13 Feb 2019 at 16:39, Igor Opaniuk <igor.opaniuk@linaro.org> wrote:
>
> Hi Simon,
>
> Seems that there is an issue in dm test framework (if understood
> everything correctly),
>
> I've noticed that dm_root is updated when dm tests are being invoked,
> and that's why the new tee udevice is allocated, consequently, the
> second invocation of probe in tee driver occurs.
> In dm_test_init() dm_root is re-inited with NULL (then it populates
> new dm tree for from scratch, probing all devices), and I can't find
> where it is done(or if it's done at all) a proper removal/cleanup of
> devices from the previous dm tree before this dm_test initialization
> is invoked (I've added a conditional breakpoint for removal of
> previously allocated tee device, and it's never being called):

I don't believe we clean up the devices when running tests.

It looks like there are some static variables in the sandbox optee
driver. That is not correct - everything should be stored in
driver-private or uclass-private data so that it goes away.

Maybe that is the problem?

[..]

Regards,
Simon