All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] rsa: Return immediately if required-key verification fails
Date: Thu, 26 Sep 2019 18:48:50 -0700	[thread overview]
Message-ID: <CAPnjgZ3ynGfM1H+8hzSv54MvsSxkCLrJeowH5Y-BBoBPWUkaDg@mail.gmail.com> (raw)
In-Reply-To: <1568815494-24570-3-git-send-email-philippe.reynes@softathome.com>

On Wed, 18 Sep 2019 at 08:05, Philippe Reynes
<philippe.reynes@softathome.com> wrote:
>
> From: Daniele Alessandrelli <daniele.alessandrelli@gmail.com>
>
> Currently, if image verification with a required key fails, rsa_verify()
> code tries to find another key to verify the FIT image. This however, is
> not the intended behavior as the documentation says that required keys
> "must be verified for the image / configuration to be considered valid".
>
> This patch fixes the issue by making rsa_verify() return immediately if
> the verification of a required key fails.
>
> Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli@gmail.com>
> ---
>  lib/rsa/rsa-verify.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2019-09-27  1:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18 14:04 [U-Boot] [PATCH 0/2] rsa signature: check that required key is really mandatory Philippe Reynes
2019-09-18 14:04 ` [U-Boot] [PATCH 1/2] pytest: vboot: add a test for required key Philippe Reynes
2019-09-27  1:48   ` Simon Glass
2019-09-27 23:28   ` sjg at google.com
2019-09-18 14:04 ` [U-Boot] [PATCH 2/2] rsa: Return immediately if required-key verification fails Philippe Reynes
2019-09-27  1:48   ` Simon Glass [this message]
2019-09-27 23:28   ` sjg at google.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3ynGfM1H+8hzSv54MvsSxkCLrJeowH5Y-BBoBPWUkaDg@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.