All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 01/13] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox
Date: Tue, 12 Jun 2018 19:29:17 -0600	[thread overview]
Message-ID: <CAPnjgZ3z0c0fdHd_ysK+PLpPqL0ZCSEy=-NJ9MOYtvAu7Nzm_Q@mail.gmail.com> (raw)
In-Reply-To: <1df4d1f7-62aa-90dd-5b32-757ab1b9ac4a@gmx.de>

Hi Heinrich,

On 11 June 2018 at 23:38, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> On 06/12/2018 07:26 AM, Simon Glass wrote:
>> This does not work at present and gives the following error:
>>
>> output: 'ld.bfd: read in flex scanner failed
>> scripts/Makefile.lib:390: recipe for target 'lib/efi_selftest/efi_selftest_miniapp_return_efi.so' failed
>>
>> It may be possible to figure this out with suitable linker magic but it
>> does not seem to be easy. Also, we will be able to run the tests on
>> sandbox without using the miniapp.
>>
>> So for now at least, disable this option.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> Changes in v5:
>> - Add new patch to disallow CMD_BOOTEFI_SELFTEST on sandbox
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>  lib/efi_selftest/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/efi_selftest/Kconfig b/lib/efi_selftest/Kconfig
>> index 59f9f36801..b52696778d 100644
>> --- a/lib/efi_selftest/Kconfig
>> +++ b/lib/efi_selftest/Kconfig
>> @@ -1,6 +1,6 @@
>>  config CMD_BOOTEFI_SELFTEST
>>       bool "Allow booting an EFI efi_selftest"
>> -     depends on CMD_BOOTEFI
>> +     depends on CMD_BOOTEFI && !SANDBOX
>
> It is sufficient to change the following line in
> lib/efi_selftest/Makefile to exclude building of
> efi_selftest_startimage_exit.o and
> efi_selftest_startimage_return.o:
>
> -ifeq ($(CONFIG_X86_64),)
> +ifeq ($(CONFIG_X86_64)$(SANDBOX),)
>
> This way we can run all other tests.

It can build them but they don't work for me. I would like to leave
this as future work as there have been plenty of changes to this
long-running series already.

Regards,
Simon

  reply	other threads:[~2018-06-13  1:29 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  5:26 [U-Boot] [PATCH v5 00/13] efi: Enable basic sandbox support for EFI loader Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 01/13] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox Simon Glass
2018-06-12  5:38   ` Heinrich Schuchardt
2018-06-13  1:29     ` Simon Glass [this message]
2018-06-12  5:26 ` [U-Boot] [PATCH v5 02/13] efi: Init the 'rows' and 'cols' variables Simon Glass
2018-06-12  5:41   ` Heinrich Schuchardt
2018-06-13  3:12     ` Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 03/13] efi: sandbox: Adjust memory usage for sandbox Simon Glass
2018-06-12  8:05   ` Alexander Graf
2018-06-12 13:48     ` Simon Glass
2018-06-12 14:02       ` Alexander Graf
2018-06-12 21:55         ` Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 04/13] sandbox: smbios: Update to support sandbox Simon Glass
2018-06-12  8:12   ` Alexander Graf
2018-06-12 13:48     ` Simon Glass
2018-06-12 14:05       ` Alexander Graf
2018-06-12 21:56         ` Simon Glass
2018-06-13 10:14           ` Alexander Graf
2018-06-12  5:26 ` [U-Boot] [PATCH v5 05/13] efi: sandbox: Add distroboot support Simon Glass
2018-06-12  8:13   ` Alexander Graf
2018-06-12 13:48     ` Simon Glass
2018-06-12 14:06       ` Alexander Graf
2018-06-12 21:59         ` Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 06/13] efi: sandbox: Add relocation constants Simon Glass
2018-06-12  8:14   ` Alexander Graf
2018-06-12  5:26 ` [U-Boot] [PATCH v5 07/13] efi: Add a comment about duplicated ELF constants Simon Glass
2018-06-12 14:10   ` [U-Boot] [U-Boot, v5, " Alexander Graf
2018-06-12  5:26 ` [U-Boot] [PATCH v5 08/13] efi: sandbox: Enable EFI loader builder for sandbox Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 09/13] efi: Split out test init/uninit into functions Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 10/13] efi: sandbox: Add a simple 'bootefi test' command Simon Glass
2018-06-12  8:28   ` Alexander Graf
2018-06-12 13:48     ` Simon Glass
2018-06-12 14:11       ` Alexander Graf
2018-06-12 21:57         ` Simon Glass
2018-06-13 10:08           ` Alexander Graf
2018-06-14 15:12             ` Simon Glass
2018-06-14 15:19               ` Alexander Graf
2018-06-12  5:26 ` [U-Boot] [PATCH v5 11/13] efi: Create a function to set up for running EFI code Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 12/13] efi: Rename bootefi_test_finish() to bootefi_run_finish() Simon Glass
2018-06-12  5:26 ` [U-Boot] [PATCH v5 13/13] buildman: Add a --boards option to specify particular boards to build Simon Glass
2018-10-15 20:07   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3z0c0fdHd_ysK+PLpPqL0ZCSEy=-NJ9MOYtvAu7Nzm_Q@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.