All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jon Mason" <jdmason@kudzu.us>
To: Christopher Clark <christopher.clark@starlab.io>,
	Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Build break with patch for "qemuboot, xen-image-minimal: enable runqemu for qemuarm64 Xen images"
Date: Sun, 1 Aug 2021 11:36:05 -0400	[thread overview]
Message-ID: <CAPoiz9zH=UK1Aj=o6rWVmF4De58hjXyZ4QBpb8N5Lus898x6Uw@mail.gmail.com> (raw)

I'm building xen-image-minimal for gem5-arm64 machine (in the meta-arm
layer) and the recent patch to add qemuarm64 support is breaking my
builds.  The patch in question is:

19347a7c4e4c qemuboot, xen-image-minimal: enable runqemu for qemuarm64
Xen images

You can see an example of the breakage here:
https://gitlab.com/jonmason00/meta-arm/-/jobs/1468242014

The problematic line is
diff --git a/recipes-extended/images/xen-image-minimal.bb
b/recipes-extended/images/xen-image-minimal.bb
index 6733801cca5f..ca6d26836c42 100644
--- a/recipes-extended/images/xen-image-minimal.bb
+++ b/recipes-extended/images/xen-image-minimal.bb
@@ -31,7 +31,7 @@ XEN_PCIBACK_MODULE_x86-64 = "kernel-module-xen-pciback"

 LICENSE = "MIT"

-inherit core-image
+inherit core-image qemuboot-xen-defaults qemuboot-xen-dtb

Reverting this line "fixes" my problem.  It seems odd to add qemu
stuff for machines that don't need it.  Is it right to add qemu stuff
to an image.bb?


Thanks,
Jon

             reply	other threads:[~2021-08-01 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 15:36 Jon Mason [this message]
2021-08-02  1:03 ` [meta-virtualization] Build break with patch for "qemuboot, xen-image-minimal: enable runqemu for qemuarm64 Xen images" Christopher Clark
2021-08-02 13:54   ` Jon Mason
2021-08-02 17:50     ` Christopher Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPoiz9zH=UK1Aj=o6rWVmF4De58hjXyZ4QBpb8N5Lus898x6Uw@mail.gmail.com' \
    --to=jdmason@kudzu.us \
    --cc=bruce.ashfield@gmail.com \
    --cc=christopher.clark@starlab.io \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.